[oe] [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER

[Andreas Müller]

On Fri, Nov 13, 2015 at 12:45 PM, Hongxu Jia <hongxu.jia at windriver.com> wrote:
> On 11/13/2015 06:36 PM, Andreas Müller wrote:
>>
>> On Fri, Nov 13, 2015 at 11:19 AM, Martin Jansa <martin.jansa at gmail.com>
>> wrote:
>>>
>>> Why not use VIRTUAL-RUNTIME variable like in other places? And if it's
>>> needed by xfce4-power-manager, then why don't you add it to RDEPENDS
>>> there?
>>>
>> networkmanager is already in RDEPENDS of xfce4-power-manager. I think
>> when building an image packagegroup-core-x11-sato there is a conflict.
>>
>> I looked into this a bit more and think:
>> 1. networkmanger support is optional so a packagroup would allow
>> conman and xfce4-power-manager live together in harmony
>> 2. I think the patch goes much to far: To have networkmanager in
>> images based on packagegroup-core-x11-sato the correct way would be to
>> write NETWORK_MANAGER = "networkmanager" in the image recipe.
>
>
> Hi Andreas,
>
> The condition of writing  NETWORK_MANAGER = "networkmanager" is
> packagegroup-core-x11-sato + xfce4-power-manager, I think it is not
> proper to test the existence of them in an image recipe.
Here I was wrong
>
> Hi Martin & Andreas,
>
> How about we still do the setting in meta-xfce's local.conf and replace
> networkmanager with variable ${NETWORK_MANAGER} in
> xfce4-power-manager's RDEPENDS.
>
> So we could globally control network manager by variable
> ${NETWORK_MANAGER} for the similar issue.
>
> //Hongxu
>>
>> Andreas
>
packagegroup-core-x11-sato ships a more or less complete
matchbox-desktop. Why build this together with xfce? OK even if you
really want to do that for some reason - I think this is a corner
case. So why adding a layer - global variable for this?

So I think
* If you want to use xfce4-power-manager + packagegroup-core-x11-sato
+ connman -> add a packageconfig in xfce4-power-manager
* If you are looking for a solution to make packagegroup-core-x11-sato
use networkmanager ask somwhere else this is not meta-xfce's job

Andreas

Andreas