[oe] [meta-oe][PATCH] talloc: rename to libtalloc and cleanup dependency mess
Jens Rehsack
rehsack at gmail.com
Wed Nov 18 10:37:25 UTC 2015
> Am 18.11.2015 um 03:08 schrieb Christopher Larson <kergoth at gmail.com>:
>
>
> On Fri, Nov 13, 2015 at 10:08 AM, Jens Rehsack <rehsack at gmail.com> wrote:
> > Am 13.11.2015 um 18:01 schrieb Christopher Larson <kergoth at gmail.com>:
> >
> > On Fri, Nov 13, 2015 at 9:56 AM, Christopher Larson <kergoth at gmail.com> wrote:
> > On Fri, Nov 13, 2015 at 8:53 AM, Jens Rehsack <rehsack at gmail.com> wrote:
> > To avoid errors when building dev-images (talloc-dev is missing), and to avoid
> > insane empty packages for that, rename talloc -> libtalloc as libtevent shows.
> >
> > With that, remove dependencies to attr/xattr and libbsd - unless explicitely
> > enabled via PACKAGECONFIG.
> >
> > Signed-off-by: Jens Rehsack <sno at netbsd.org>
> >
> > Our recipe names should be named based on the upstream project name, not the library they happen to ship.
> >
> > Instead, either we could we should kill all the libtalloc bits in the PACKAGES var, and let the debian shlib renaming handle renaming talloc* to libtalloc*, or add a talloc-dev that pulls in libtalloc-dev & pytalloc-dev.
> >
> > I just realized this may sound critical, but that wasn't intended. The other changes look great, thanks for your work on making those dependencies optional, it's good stuff.
>
> In that case - please take me by the hand and explain a bit more detailed
>
> > Instead, either we could we should kill all the libtalloc bits in the PACKAGES var, and let the debian shlib renaming handle renaming talloc* to libtalloc*
>
> since I have no clue what you try to guide me.
>
> I'm not able to reproduce any error when building an image. Add libtalloc and dev-pkgs, and it builds just fine. You can't add talloc, as there is no talloc package emitted.
>
> That said, what I was suggesting was something along the lines of https://gist.github.com/kergoth/ead0e1d2682a9e9fcd59 -- debian.bbclass will automatically rename the ${PN}, ${PN}-dev, and ${PN}-dbg packages based on the library soname, so will end up named libtalloc* anyway if you use it. Since the main packages weren't emitted at all, it was pointless complexity in the packaging to add libtalloc* explicitly.
Well, I had the problem and one of our contributors either that samba's dependency on talloc prevents creating a dev-image (not a regular image!), because no -dev image was emitted but talloc-dev was added as RDEPENDS automatically because it might contain header files or so (no idea).
I don't see the win in https://gist.github.com/kergoth/ead0e1d2682a9e9fcd59#file-talloc-patch-L25-L34 vs. renaming the recipe, but during meta-java cleanup and packaging openjdk-8 I encountered lot's of issues with RPROVIDES - so I try to avoid it where possible. And - as said - libtevent (http://cgit.openembedded.org/meta-openembedded/tree/meta-networking/recipes-support/libtevent) is currently there and accepted, don't see adopting talloc -> libtalloc doing similar.
You can HL me in #yocto if I miss something which might be clarified in a short talk.
Cheers
--
Jens Rehsack - rehsack at gmail.com
More information about the Openembedded-devel
mailing list