[oe] [meta-oe][PATCH] lmsensors: allow lmsensors-isatools to be empty

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org [mailto:openembedded-devel-
> bounces at lists.openembedded.org] On Behalf Of Martin Jansa
> Sent: Friday, November 20, 2015 7:37 PM
> To: openembedded-devel at lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH] lmsensors: allow lmsensors-isatools to be empty
> 
> On Fri, Nov 20, 2015 at 07:22:04PM +0800, jackie.huang at windriver.com wrote:
> > From: Jackie Huang <jackie.huang at windriver.com>
> >
> > isadump and isaset are only built on x86 machines,
> > so allow lmsensors-isatools to be empty.
> >
> > Signed-off-by: Jackie Huang <jackie.huang at windriver.com>
> > ---
> >  meta-oe/recipes-support/lm_sensors/lmsensors_3.4.0.bb | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta-oe/recipes-support/lm_sensors/lmsensors_3.4.0.bb b/meta-oe/recipes-
> support/lm_sensors/lmsensors_3.4.0.bb
> > index 62ea131..364eb9e 100644
> > --- a/meta-oe/recipes-support/lm_sensors/lmsensors_3.4.0.bb
> > +++ b/meta-oe/recipes-support/lm_sensors/lmsensors_3.4.0.bb
> > @@ -131,3 +131,7 @@ RDEPENDS_${PN}-pwmconfig = "${PN}-fancontrol"
> >  FILES_${PN}-isatools = "${sbindir}/isa*"
> >  FILES_${PN}-isatools-dbg = "${sbindir}/.debug/isa*"
> >  FILES_${PN}-isatools-doc = "${mandir}/man8/isa*"
> > +
> > +# isadump and isaset are only built on x86 machines,
> > +# so allow it to be empty.
> > +ALLOW_EMPTY_${PN}-isatools = "1"
> 
> Why should anyone on !x86 install lmsensors-isatools package?
> 
> And if (s)he does, then why should s(he) be happy with empty package?

Sorry, this is not appropriate, we fixed it another way in our layer, please ignore it.

Thanks,
Jackie

> 
> Package manager saying that the package doesn't exist is much better
> user experience than it happily installing completely useless empty
> package.
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com