[oe] [meta-initramfs][PATCH] kexecboot_0.6: fix build with gcc 5

[Khem Raj]

On Thu, Sep 24, 2015 at 2:11 PM, Andrea Adami <andrea.adami at gmail.com> wrote:
> On Thu, Sep 24, 2015 at 6:55 AM, Khem Raj <raj.khem at gmail.com> wrote:
>
>> On Wed, Sep 23, 2015 at 3:29 PM, Andrea Adami <andrea.adami at gmail.com>
>> wrote:
>> > +-inline void
>> > ++extern inline void
>>
>> would it be better to make it static inline ?
>>
>
> Apparently not...

well I meant to move the defintion of this function to header and not
just modify the declaration.

>
> rgba2comp is used in rgb.c and fb.c.
> Making it static inline leads to the following error:
>
> | In file included from
> /tmp/build/tmp-glibc/work/poodle-oe-linux-gnueabi/kexecboot/0.6-r0/kexecboot-0.6/fb.h:39:0,
> |                  from
> /tmp/build/tmp-glibc/work/poodle-oe-linux-gnueabi/kexecboot/0.6-r0/kexecboot-0.6/gui.h:25,
> |                  from
> /tmp/build/tmp-glibc/work/poodle-oe-linux-gnueabi/kexecboot/0.6-r0/kexecboot-0.6/kexecboot.c:43:
> |
> /tmp/build/tmp-glibc/work/poodle-oe-linux-gnueabi/kexecboot/0.6-r0/kexecboot-0.6/rgb.h:55:1:
> warning: 'rgba2comp' declared 'static' but never defined [-Wunused-function]
> |  rgba2comp(kx_rgba rgba, kx_ccomp *red, kx_ccomp *green,
> |  ^
> | arm-oe-linux-gnueabi-gcc  -march=armv5e -marm  -mthumb-interwork
> --sysroot=/tmp/build/tmp-glibc/sysroots/poodle -Wall -O2 -pipe -g
> -feliminate-unused-debug-types  -Wl,-O1 -Wl,--hash-style=gnu
> -Wl,--as-needed -o kexecboot util.o cfgparser.o devicescan.o evdevs.o fb.o
> gui.o menu.o xpm.o rgb.o tui.o kexecboot.o fstype/fstype.o machine/zaurus.o
> | fb.o: In function `compose_color':
> |
> /tmp/build/tmp-glibc/work/poodle-oe-linux-gnueabi/kexecboot/0.6-r0/kexecboot-0.6/fb.c:34:
> undefined reference to `rgba2comp'
> | collect2: error: ld returned 1 exit status
>
> BTW, I didn't test that patch compiling with gcc 4 yet. It is just meant as
> a fix for gcc 5 w/out  touching much code.
> Thanks for your review, suggestions are appreciated!
>
> Cheers
> Andrea
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel