[oe] "libgudev" fails to build with current master

[Martin Jansa]

On Fri, Sep 25, 2015 at 01:22:37AM +0200, Andreas Müller wrote:
> On Thu, Sep 24, 2015 at 6:45 PM, Andreas Müller
> <schnitzeltony at googlemail.com> wrote:
> > On Thu, Sep 24, 2015 at 3:40 PM, Mike Looijmans <mike.looijmans at topic.nl> wrote:
> >> | checking for LIBUDEV... no
> >> | configure: error: Package requirements (libudev >= 199) were not met:
> >> |
> >> | Requested 'libudev >= 199' but version of libudev is 182
> >> |
> >> ...
> >>
> >> ERROR: Task 5548
> >> (/.../meta-oe/meta-oe/recipes-gnome/libgudev/libgudev_230.bb, do_configure)
> >> failed with exit code '1'
> >>
> > Which init system are you using - I guess not systemd
> >
> Let's assume it is not systemd. Could you try attached  0001.. for
> oe-core and 0002.. foe meta-oe and give feedback. I tested these for
> systemd distro without new issues.
> 
> Andreas

> From 384c763f66d5f49b967253e8e5d272822552a524 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Andreas=20M=C3=BCller?= <schnitzeltony at googlemail.com>
> Date: Fri, 25 Sep 2015 01:04:31 +0200
> Subject: [PATCH] udev: add PROVIDES = "libgudev"
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> With the last update of systemd libgudev was splitted out of systemd. To make
> packages depending on libgudev happy, a recipe building libgudev was created in
> meta-oe and the dependencies were modified from udev to libgudev.
> 
> This works fine for distros using systemd as init system, but distros not using
> build udev which provides libgudev.
> 
> Signed-off-by: Andreas Müller <schnitzeltony at googlemail.com>
> ---
>  meta/recipes-core/udev/udev.inc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
> index a00dad5..c378ae3 100644
> --- a/meta/recipes-core/udev/udev.inc
> +++ b/meta/recipes-core/udev/udev.inc
> @@ -15,6 +15,8 @@ LDFLAGS += "-lrt"
>  DEPENDS = "glib-2.0 libusb usbutils pciutils glib-2.0-native gperf-native libxslt-native util-linux"
>  RPROVIDES_${PN} = "hotplug"
>  
> +PROVIDES = "libgudev"
> +
>  SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz \
>             file://0001-Fixing-keyboard_force_release.sh-shell-script-path.patch \
>             file://avoid-mouse-autosuspend.patch \
> -- 
> 2.1.0
> 

> From e83235a777880c343fce9f286f50678b237620dd Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Andreas=20M=C3=BCller?= <schnitzeltony at googlemail.com>
> Date: Fri, 25 Sep 2015 01:17:01 +0200
> Subject: [PATCH] libgudev: skip recipe for distros not using systemd as init
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> for those systems udev provides libgudev
> 
> Signed-off-by: Andreas Müller <schnitzeltony at googlemail.com>
> ---
>  meta-oe/recipes-gnome/libgudev/libgudev_230.bb | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta-oe/recipes-gnome/libgudev/libgudev_230.bb b/meta-oe/recipes-gnome/libgudev/libgudev_230.bb
> index 39fc1c4..9e457d2 100644
> --- a/meta-oe/recipes-gnome/libgudev/libgudev_230.bb
> +++ b/meta-oe/recipes-gnome/libgudev/libgudev_230.bb
> @@ -11,3 +11,9 @@ LICENSE = "LGPLv2.1"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
>  
>  inherit gnomebase
> +
> +# in non systemd distros udev builds libgudev
> +python () {
> +    if not bb.utils.contains ('DISTRO_FEATURES', 'systemd', True, False, d):
> +        raise bb.parse.SkipPackage("'systemd' not in DISTRO_FEATURES")
> +}

Cannot we use REQUIRED_DISTRO_FEATURES + inherit distro_features_check
for this one?

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20150925/caa4bb0c/attachment-0002.sig>