[oe] [meta-qt5][PATCH 1/2] qtdeclarative: fix compilation of examples/qquickviewcomparison

Martin Jansa martin.jansa at gmail.com
Mon Apr 25 21:24:42 UTC 2016


I was testing if this is still needed with latest 5.6 currently in
jansa/master. Or if I can just drop this again when upgrading to newer
revisions.

Did you see this issue only with 5.6 revisions currently in master or with
5.6 revisions sent by Andreas which are now in master-next and where even
qtbase examples fail to build in default setup as reported in separate
e-mail?
http://lists.openembedded.org/pipermail/openembedded-devel/2016-April/107077.html

On Mon, Apr 25, 2016 at 8:07 PM, Denys Dmytriyenko <denis at denix.org> wrote:

> Martin,
>
> Any comments?
>
>
> On Wed, Apr 20, 2016 at 02:27:10PM -0400, Denys Dmytriyenko wrote:
> > Ping. These 2 have been sitting in master-next as well for quite some
> time.
> > Any updates?
> >
> >
> > On Thu, Mar 31, 2016 at 08:47:22PM -0400, Denys Dmytriyenko wrote:
> > > From: Denys Dmytriyenko <denys at ti.com>
> > >
> > >
> git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cpp:180:14:
> error: 'QCoreApplication' has not been declared
> > >           if
> (!QCoreApplication::arguments().contains(QStringLiteral("--no_render_alpha")))
> > >
> > > Signed-off-by: Denys Dmytriyenko <denys at ti.com>
> > > ---
> > >  ...omparison-fix-QCoreApplication-has-not-be.patch | 28
> ++++++++++++++++++++++
> > >  recipes-qt/qt5/qtdeclarative_git.bb                |  1 +
> > >  2 files changed, 29 insertions(+)
> > >  create mode 100644
> recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
> > >
> > > diff --git
> a/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
> b/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
> > > new file mode 100644
> > > index 0000000..1687fbe
> > > --- /dev/null
> > > +++
> b/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
> > > @@ -0,0 +1,28 @@
> > > +From 1cdd3278a0b1508640d983720782d39eb919caaf Mon Sep 17 00:00:00 2001
> > > +From: Denys Dmytriyenko <denys at ti.com>
> > > +Date: Thu, 31 Mar 2016 19:38:58 -0400
> > > +Subject: [PATCH] qquickviewcomparison: fix QCoreApplication has not
> been
> > > + declared error
> > > +
> > > +Upstream-Status: Pending
> > > +
> > > +Signed-off-by: Denys Dmytriyenko <denys at ti.com>
> > > +---
> > > + examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h | 1 +
> > > + 1 file changed, 1 insertion(+)
> > > +
> > > +diff --git
> a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h
> b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h
> > > +index 5b86c93..e77514e 100644
> > > +--- a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h
> > > ++++ b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h
> > > +@@ -44,6 +44,7 @@
> > > + #include <QWidget>
> > > + #include <QQuickWidget>
> > > + #include <QQuickView>
> > > ++#include <QCoreApplication>
> > > +
> > > + QT_FORWARD_DECLARE_CLASS(QRadioButton)
> > > + QT_FORWARD_DECLARE_CLASS(QCheckBox)
> > > +--
> > > +2.2.0
> > > +
> > > diff --git a/recipes-qt/qt5/qtdeclarative_git.bb b/recipes-qt/qt5/
> qtdeclarative_git.bb
> > > index 93442fb..9274d00 100644
> > > --- a/recipes-qt/qt5/qtdeclarative_git.bb
> > > +++ b/recipes-qt/qt5/qtdeclarative_git.bb
> > > @@ -15,6 +15,7 @@ DEPENDS += "qtbase"
> > >
> > >  SRC_URI += " \
> > >      file://0001-qmltestexample-fix-link.patch \
> > > +
> file://0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch \
> > >  "
> > >
> > >  EXTRA_OEMAKE +=
> "QMAKE_SYNCQT=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/syncqt"
> > > --
> > > 2.2.0
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel at lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



More information about the Openembedded-devel mailing list