[oe] [PATCH 1/2] protobuf: add protobuf-c recipe

[Felipe Ferreri Tonello]

Hi Bruce,

On 20/04/16 15:32, Bruce Ashfield wrote:
> On Wed, Apr 20, 2016 at 4:32 AM, Felipe Ferreri Tonello <
> eu at felipetonello.com> wrote:
> 
>> Hi Bruce,
>>
>> On 19/04/16 20:55, Bruce Ashfield wrote:
>>> On Tue, Apr 19, 2016 at 3:46 PM, Bruce Ashfield <
>> bruce.ashfield at gmail.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Apr 19, 2016 at 11:40 AM, Felipe F. Tonello <
>> eu at felipetonello.com>
>>>> wrote:
>>>>
>>>>> Initial version of recipe. The main package could be split into two to
>>>>> separate the compiler. This also applies to protobuf recipe.
>>>>>
>>>>>
>>>> More precisely, this is the initial version outside of
>> meta-virtualization
>>>> which enea added
>>>> in 2012 :) It was added as a dependency for criu (hence why it was put
>> in
>>>> meta-virt).
>>>>
>>>> If we move it to meta-oe, we at least owe that other implementation a
>>>> reference in the commit.
>>>>
>>>>
>>> s/if/when/.
>>>
>>> I'm happy to purge all the protobuf* recipes from meta-virt, since they
>>> were only there as
>>> support mechanisms (and I wasn't involved in their original merge).
>>>
>>> But if you can take a look at what's in the meta-virt recipe, I'll do
>> some
>>> runtime testing with your
>>> variant here, and drop the meta-virt ones when I can confirm criu works.
>>>
>>
>> Regular protobuf recipe is already part of meta-oe. That's why I added
>> this one there too.
>>
> 
> Sure. That's obvious from the layer index, as is the existence of the one
> in meta-virt.

I didn 't take it from meta-virt. The original protobuf recipe is in
meta-oe.

> 
> Credit, where credit is due. It's not my work, so I'm not asking for any
> credit,
> but simply duplicating something that already exists without a nod to the
> older one
> isn't ideal.
> 
> All I was asking was that if you could a link to the meta-virt one in the
> commit header
> so that someone not familiar with the layer index can see the two options
> .. and
> at the same time I was wondering if you'd seen the meta-virt one and did
> this one
> differently for technical reasons. That makes it easier for me to drop
> recipes as they
> get cloned around to new (and better) locations.

I am fine with that. Can you please provide the git hash so I can link it?

Thanks in advance,
Felipe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0x92698E6A.asc
Type: application/pgp-keys
Size: 7195 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20160428/76f6a065/attachment-0002.bin>