[oe] [meta-java][PATCH 1/3] java-bootstrapping: Do not rely on hardcoded paths
Maxin B. John
maxin.john at intel.com
Thu Apr 28 11:43:02 UTC 2016
Hi Erkka,
Have a couple of comments about this patch-set:
1. Upstream-Status is missing
2. cacao build fails after applying this patch.
On Fri, Apr 22, 2016 at 01:48:26PM +0300, Erkka Kääriä wrote:
> Various paths to files are hardcoded in either helper scripts or the
> resulting binaries (like path to Java class libraries). While this works
> well when using the files on the build machine, things start breaking
> down when the sstate gets shared between multiple workers in CI, as
> the paths between workers can differ.
>
> Instead of using these hardcoded paths, form the paths at runtime and pass them as parameters when required.
>
<snip>
> -do_install_append () {
> - rm ${D}/${bindir}/java
> -}
> -
> -do_install_append_class-native () {
> - ln -sf cacao ${D}/${bindir}/java
> -}
# bitbake cacao
...
NOTE: Executing RunQueue Tasks
ERROR: cacao-1.6.1-r0 do_package: QA Issue: cacao: Files/directories were installed but not shipped in any package:
/usr/bin/java
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
cacao: 1 installed and not shipped files. [installed-vs-shipped]
ERROR: cacao-1.6.1-r0 do_package: Fatal QA errors found, failing task.
ERROR: cacao-1.6.1-r0 do_package: Function failed: do_package
Please fix it.
Best Regards,
Maxin
More information about the Openembedded-devel
mailing list