[oe] [meta-networking][PATCH 1/3] ifenslave: fix QA warning for GNU_HASH

[Khem Raj]

> On Aug 19, 2016, at 3:09 AM, André Draszik <git at andred.net> wrote:
> 
> On Fr, 2016-08-19 at 18:04 +0800, Yi Zhao wrote:
>> Set LDFLAGS explicitly for do_compile
>> 
>> Signed-off-by: Yi Zhao <yi.zhao at windriver.com>
>> ---
>>  meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb
>> b/meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb
>> index acc0864..385bc80 100644
>> --- a/meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb
>> +++ b/meta-networking/recipes-support/ifenslave/ifenslave_1.1.0.bb
>> @@ -10,7 +10,7 @@ SRC_URI[md5sum] = "56126cd1013cefe0ce6f81613e677bdd"
>>  SRC_URI[sha256sum] =
>> "7917bf34de80a2492eb225adf9168c83a4854ac8a008ed0fd5b3fd147ccd3041"
>> 
>>  do_compile() {
>> -    ${CC} ifenslave.c -o ifenslave
>> +    ${CC} ${LDFLAGS} ifenslave.c -o ifenslave
> 
> While you're fixing the gcc invocation here, wouldn't it make sense to add
> CFLAGS as well? (Maybe in a separate patch).
> 

yeah or into two distinct steps of compile and link.

> 
> Cheers,
> Andre'
> 
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20160819/73ce24cf/attachment-0002.sig>