[oe] [PATCH 2/2] thin-provisioning-tools: add version 0.6.3

[Martin Jansa]

On Wed, Aug 31, 2016 at 03:26:14AM -0400, Hongxu Jia wrote:
> It is required by lvm2, since lvm2 could find modprobe correctly
> ------
> |lvm lvchange -a y --config  devices { preferred_names=["^/dev/mapper/",
> "^/dev/md/", "^/dev/sd"] }  wrl/pool00
> |/usr/sbin/thin_check: execvp failed: No such file or directory
> | Check of pool wrl/pool00 failed (status:2). Manual repair required!
> ------
> 
> The thin-provisioning-tools provides /usr/sbin/thin_check.
> 
> Signed-off-by: Hongxu Jia <hongxu.jia at windriver.com>
> ---
>  meta-oe/recipes-support/lvm2/lvm2.inc              |  2 +-
>  ...01-do-not-strip-pdata_tools-at-do_install.patch | 33 ++++++++++++++++++++++
>  .../thin-provisioning-tools_0.6.3.bb               | 18 ++++++++++++
>  3 files changed, 52 insertions(+), 1 deletion(-)
>  create mode 100644 meta-oe/recipes-support/thin-provisioning-tools/files/0001-do-not-strip-pdata_tools-at-do_install.patch
>  create mode 100755 meta-oe/recipes-support/thin-provisioning-tools/thin-provisioning-tools_0.6.3.bb
> 
> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
> index e452f11..e2feeb3 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
> @@ -66,6 +66,6 @@ TARGET_CC_ARCH += "${LDFLAGS}"
>  FILES_${PN} += "${libdir}/device-mapper/*.so ${base_libdir}/udev"
>  FILES_${PN}-dbg += "${libdir}/device-mapper/.debug"
>  
> -RDEPENDS_${PN} = "bash"
> +RDEPENDS_${PN} = "bash thin-provisioning-tools"
>  
>  CONFFILES_${PN} += "${sysconfdir}/lvm/lvm.conf"
> diff --git a/meta-oe/recipes-support/thin-provisioning-tools/files/0001-do-not-strip-pdata_tools-at-do_install.patch b/meta-oe/recipes-support/thin-provisioning-tools/files/0001-do-not-strip-pdata_tools-at-do_install.patch
> new file mode 100644
> index 0000000..b4cdda1
> --- /dev/null
> +++ b/meta-oe/recipes-support/thin-provisioning-tools/files/0001-do-not-strip-pdata_tools-at-do_install.patch
> @@ -0,0 +1,33 @@
> +From e8be402e20cbdfbd8192a171ac9904d9362103bf Mon Sep 17 00:00:00 2001
> +From: Hongxu Jia <hongxu.jia at windriver.com>
> +Date: Wed, 31 Aug 2016 01:35:40 -0400
> +Subject: [PATCH] do not strip pdata_tools at do_install
> +
> +It caused QA Issue:
> +--------------
> +|ERROR: QA Issue: File '/usr/sbin/pdata_tools' from thin-provisioning-tools
> +was already stripped, this will prevent future debugging! [already-stripped]
> +--------------
> +
> +Upstream-Status: Inappropriate [oe specific]
> +
> +Signed-off-by: Hongxu Jia <hongxu.jia at windriver.com>
> +---
> + Makefile.in | 1 -
> + 1 file changed, 1 deletion(-)
> +
> +diff --git a/Makefile.in b/Makefile.in
> +index 4264191..ac22042 100644
> +--- a/Makefile.in
> ++++ b/Makefile.in
> +@@ -189,7 +189,6 @@ distclean: clean
> + install: bin/pdata_tools
> + 	$(INSTALL_DIR) $(BINDIR)
> + 	$(INSTALL_PROGRAM) bin/pdata_tools $(BINDIR)
> +-	$(STRIP) $(BINDIR)/pdata_tools
> + 	ln -s -f pdata_tools $(BINDIR)/cache_check
> + 	ln -s -f pdata_tools $(BINDIR)/cache_dump
> + 	ln -s -f pdata_tools $(BINDIR)/cache_metadata_size
> +-- 
> +2.8.1
> +
> diff --git a/meta-oe/recipes-support/thin-provisioning-tools/thin-provisioning-tools_0.6.3.bb b/meta-oe/recipes-support/thin-provisioning-tools/thin-provisioning-tools_0.6.3.bb
> new file mode 100755
> index 0000000..c2ba95c
> --- /dev/null
> +++ b/meta-oe/recipes-support/thin-provisioning-tools/thin-provisioning-tools_0.6.3.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "A suite of tools for manipulating the metadata of the dm-thin device-mapper target."

This looks too long for SUMMARY.

> +HOMEPAGE = "https://github.com/jthornber/thin-provisioning-tools"
> +LICENSE = "GPLv3"
> +SECTION = "devel"
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> +S = "${WORKDIR}/git"
> +
> +SRC_URI = "git://github.com/jthornber/thin-provisioning-tools \
> +           file://0001-do-not-strip-pdata_tools-at-do_install.patch \
> +          "

Closing quote should be first character (without indentation).

> +
> +SRCREV = "49bfc12e9c7956c1ac134b24afbe1a6a602ce7d5"
> +
> +DEPENDS += "expat libaio boost"
> +
> +inherit autotools
> +B = "${S}"

Why not autotools-brokensep?
> -- 
> 2.8.1
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20160831/97ed52dc/attachment-0002.sig>