[oe] [meta-java][PATCH] move from bb.data.getVar(x, d, 1) to d.getVar(x, True)

[Otavio Salvador]

On Mon, Dec 5, 2016 at 10:13 AM, Patrick Ohly <patrick.ohly at gmx.de> wrote:
> On Tue, 2016-11-29 at 13:16 -0700, Christopher Larson wrote:
>> On Tue, Nov 29, 2016 at 9:48 AM, Cody P Schafer <dev at codyps.com> wrote:
>>
>> > bb.data.getVar was removed, need to use the modern mechanism.
>> >
>> > Signed-off-by: Cody P Schafer <dev at codyps.com>
>> > ---
>> >  classes/java-library.bbclass              |  4 ++--
>> >  recipes-core/icedtea/icedtea7-native.inc  |  2 +-
>> >  recipes-core/openjdk/openjdk-7-common.inc |  2 +-
>> >  recipes-core/openjdk/openjdk-8-common.inc | 10 +++++-----
>> >  recipes-core/openjdk/openjdk-common.inc   |  6 +++---
>> >  5 files changed, 12 insertions(+), 12 deletions(-)
>> >
>> > diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
>> > index 144cd2f..58d5a40 100644
>> > --- a/classes/java-library.bbclass
>> > +++ b/classes/java-library.bbclass
>> > @@ -23,8 +23,8 @@ def java_package_name(d):
>> >    pre=""
>> >    post=""
>> >
>> > -  bpn = bb.data.getVar('BPN', d, 1)
>> > -  ml = bb.data.getVar('MLPREFIX', d, 1)
>> > +  bpn = d.getVar('BPN', True)
>> > +  ml = d.getVar('MLPREFIX', True)
>> >
>>
>> If you’re working on master, even the ‘, True’ is no longer needed, FYI.
>
> I suspect that meta-java master is meant to work with more than just
> bitbake master, so keeping the parameter makes sense.
>
> I think the change is okay and I'd love to see it merged as soon as
> possible. In Ostro OS, updating to bitbake and OE-core master is blocked
> by this meta-java incompatibility with bitbake master.
>
> Can someone with commit rights to meta-java please merge it?

We are on it. Fabio is testing the meta-java patches for merging.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750