[oe] [meta-networking][PATCH 03/11] samba: remove unused variable DISABLE_STATIC

Joe MacDonald Joe_MacDonald at mentor.com
Sat Dec 17 15:46:19 UTC 2016


[Re: [oe] [meta-networking][PATCH 03/11] samba: remove unused variable DISABLE_STATIC] On 16.12.17 (Sat 14:12) Andreas Oberritter wrote:

> On 17.12.2016 04:05, Joe MacDonald wrote:
> > Oh, I just realized this one sneaked back in despite my having thrown it
> > out at least twice now.  I've already rejected it in patchwork, but if
> > anyone is picking this up off the mailing list, DISABLE_STATIC is very
> > much still needed AFAICT.
> 
> Sorry, I didn't recognize it as a global variable.

No worries, honest mistake, it does look a little odd when you first
encounter it.  :-)

-J.

> 
> Regards,
> Andreas
> 
> > 
> > -J.
> > 
> > [[oe] [meta-networking][PATCH 03/11] samba: remove unused variable DISABLE_STATIC] On 16.12.16 (Fri 21:15) Joe MacDonald wrote:
> > 
> >> From: Andreas Oberritter <obi at opendreambox.org>
> >>
> >> Signed-off-by: Andreas Oberritter <obi at opendreambox.org>
> >> Signed-off-by: Joe MacDonald <joe_macdonald at mentor.com>
> >> ---
> >>  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> >> index aabc043..c9e0953 100644
> >> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> >> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> >> @@ -93,7 +93,6 @@ EXTRA_OECONF += "--enable-fhs \
> >>                   --with-libiconv=${STAGING_DIR_HOST}${prefix} \
> >>                   --with-pam --with-pammodulesdir=${base_libdir}/security \
> >>                  "
> >> -DISABLE_STATIC = ""
> >>  
> >>  LDFLAGS += "-Wl,-z,relro,-z,now ${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
> >>  
> >> -- 
> >> 1.9.1
> >>
> >>
> >>
> 
-- 
-Joe MacDonald.
:wq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20161217/a88ab2d2/attachment-0002.sig>


More information about the Openembedded-devel mailing list