[oe] [PATCH] hwloc: Add

[Christopher Larson]

On Thu, Dec 22, 2016 at 2:34 PM, Martin Jansa <martin.jansa at gmail.com>
wrote:

> SUMMARY is for short summary, put long one into DESCRIPTION and create
> short one for SUMMARY.
>
> Also missing sha265sum, so I doubt it was tested properly.
>
> On Thu, Dec 22, 2016 at 9:02 PM, Haris Okanovic <haris.okanovic at ni.com>
> wrote:
>
> > https://www.open-mpi.org/projects/hwloc/
> >
> > "The Portable Hardware Locality (hwloc) software package provides a
> > portable abstraction (across OS, versions, architectures, ...) of the
> > hierarchical topology of modern architectures, including NUMA memory
> > nodes, sockets, shared caches, cores and simultaneous multithreading.
> > It also gathers various system attributes such as cache and memory
> > information as well as the locality of I/O devices such as network
> > interfaces, InfiniBand HCAs or GPUs."
> >
> > This recipe adds libhwloc and lstopo utility as two packages.
> >
> > Testing: Built in OE/Krogoth. Installed to x86_64 machine. Successfully
> > ran `lstopo` and verified it printed correct CPU and cache info.
> >
> > Signed-off-by: Haris Okanovic <haris.okanovic at ni.com>
> > ---
> >  meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb | 25
> > +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >  create mode 100644 meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
> >
> > diff --git a/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
> > b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
> > new file mode 100644
> > index 0000000..3a88f5b
> > --- /dev/null
> > +++ b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
> > @@ -0,0 +1,25 @@
> > +SUMMARY = "The Portable Hardware Locality (hwloc) software package \
> > + provides a portable abstraction of the hierarchical topology of modern
> \
> > + architectures."
> > +HOMEPAGE = "https://www.open-mpi.org/software/hwloc/"
> > +SECTION = "base"
> > +LICENSE = "BSD"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=3282e20dc3cec311deda3c6d4b1f99
> 0b"
> > +
> > +SRC_URI = "https://www.open-mpi.org/software/${PN}/v1.11/
> > downloads/${BP}.tar.bz2"
> > +SRC_URI[md5sum] = "96c34136ff416d2b13a7821c27477bed"
> > +
> > +inherit autotools
> > +
> > +# Split hwloc library into separate subpackage
> > +PACKAGES_prepend = "lib${PN}"
> > +FILES_lib${PN} += "${libdir}/lib${PN}.so*"
> > +${PN}_RDEPENDS += "lib${PN}"
> > +
> > +do_install_append() {
> > +    # Let ldconfig do it's thing, no need for these symlinks
> > +    test -L "${D}${libdir}/lib${PN}.so.5"
> > +    test -L "${D}${libdir}/lib${PN}.so"
> > +    rm "${D}${libdir}/lib${PN}.so.5"
> > +    rm "${D}${libdir}/lib${PN}.so"
>

This link manipulation is also inconsistent with every other recipe. It’s
not appropriate. If your distro wants to rely on ldconfig to handle the
links, then your distro could do this for all recipes rather than just one.
This isn’t how things are done in our existing recipes.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics