[oe] [meta-qt5][PATCH] qtwebengine: build examples by default

[Otavio Salvador]

On Tue, Feb 2, 2016 at 7:45 AM, Samuli Piippo
<samuli.piippo at theqtcompany.com> wrote:
> On 01.02.2016 13:14, Otavio Salvador wrote:
>>
>> On Mon, Feb 1, 2016 at 8:44 AM, Samuli Piippo
>> <samuli.piippo at theqtcompany.com> wrote:
>>>
>>> On 30.01.2016 16:13, Otavio Salvador wrote:
>>>>
>>>>
>>>> On Wed, Jan 27, 2016 at 12:58 PM, Manuel Bachmann
>>>> <manuel.bachmann at iot.bzh> wrote:
>>>>>
>>>>>
>>>>> From: Manuel Bachmann <mbc at iot.bzh>
>>>>>
>>>>> Just as we do for qtwebkit, let us have a patch to build
>>>>> qtwebengine examples by default.
>>>>>
>>>>> Otherwise, the "qtwebengine-examples" package will be
>>>>> empty, and attempting to add it with "IMAGE_INSTALL_append"
>>>>> will result in an error message.
>>>>>
>>>>> Signed-off-by: Manuel Bachmann <manuel.bachmann at iot.bzh>
>>>>
>>>>
>>>>
>>>> This should be a distro option and not enabled for everyone.
>>>>
>>>
>>> Also there is no need to do this with a patch, same result is achieved
>>> with:
>>>
>>> EXTRA_QMAKEVARS_PRE += "QT_BUILD_PARTS+=examples"
>>>
>>> Maybe this could be added to qt5.inc as a PACKAGECONFIG option?
>>> This would allow easily enable examples on any qt module.
>>
>>
>> It is:
>>
>>
>> https://github.com/meta-qt5/meta-qt5/blob/master/recipes-qt/qt5/qtbase_git.bb#L67
>>
>
> Enabling the PACKAGECONFIG[examples] from qtbase means that every qt module
> will build their examples.
> If added to qt5.inc, it would build examples only from a qt module you
> bbappend with PACKAGECONFIG += examples.

Agreed; I support this approach if you are willing to send a patch;
otherwise  I can do it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750