[oe] [PATCH 2/2] iscsitarget: skip the arch test for kernel modules

[Joe MacDonald]

On Wed, Nov 25, 2015 at 3:27 AM, <jackie.huang at windriver.com> wrote:

> From: Jackie Huang <jackie.huang at windriver.com>
>
> Kernel modules may not have the same architecture as user space.
> So we tell INSANE_SKIP to skip checking the arch for the modules.
> This is consistent with other kernel modules and the kernel recipe.
>

This one still hasn't been merged and since iscsitarget is currently
unbuildable, I'm not in a rush to merge this one particularly since I'm not
really clear on the logic underlying the change.  I searched the archives
and found your response to Martin was essentially "see my netmap-modules
patch for an explanation" and in that one the explanation was basically
"this is the way other kernel modules do it".  I merged that one but now
I'm thinking I shouldn't have without more careful consideration.  Am I
correct in thinking that this problem only shows up when you're building
for multilib?  I've reverted "netmap-modules: Modules may not have the same
arch as userspace" in my contrib tree at
http://git.openembedded.org/meta-openembedded-contrib/log/?h=joeythesaint/meta-networking-next
and my initial test builds showed no QA issues related to netmap-modules
and the arch checks.  So I started looking around for other kernel modules
doing something similar and I don't actually see this
"INSANE_SKIP_kernel-module-*" construct being used anywhere else in meta-oe
or poky (and at the least I would expect something like cryptodev-module to
need it, it looks like an analogue to me).  Can you fill me in on what's
special with iscsitarget and netmap, because even if it is a multilib
issue, why wouldn't that be showing up for other kernel modules built in
poky?

Thanks.

-J.


>
> Signed-off-by: Jackie Huang <jackie.huang at windriver.com>
> ---
>  .../recipes-extended/iscsitarget/iscsitarget_1.4.20.3+svn502.bb        |
> 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git
> a/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+
> svn502.bb
> b/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+
> svn502.bb
> index 9d49759..9db16bc 100644
> --- a/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+
> svn502.bb
> +++ b/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+
> svn502.bb
> @@ -54,3 +54,6 @@ FILES_${PN} += "${sbindir} \
>
>  RDEPENDS_${PN} = "kernel-module-iscsi-trgt"
>  RRECOMMENDS_${PN} = "kernel-module-crc32c kernel-module-libcrc32c"
> +
> +# Skip the arch test for kernel modules
> +INSANE_SKIP_kernel-module-iscsi-trgt = "arch"
> --
> 2.3.5
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



-- 
Joe MacDonald
:wq