[oe] [meta-networking][PATCH] samba: move RDEPENDS of perl from samba to samba-pidl

[Jens Rehsack]

> Am 05.01.2016 um 12:32 schrieb Mike Looijmans <mike.looijmans at topic.nl>:
> 
> On 04-01-16 20:06, Jens Rehsack wrote:
>> samba-pidl is the package containing the perl-extension, so RDEPENDS
>> must include perl for samba-pidl, not for samba.
>> 
>> Signed-off-by: Jens Rehsack <sno at netbsd.org>
>> ---
>>  meta-networking/recipes-connectivity/samba/samba_4.1.12.bb | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
>> index 5b343f2..de1f033 100644
>> --- a/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
>> +++ b/meta-networking/recipes-connectivity/samba/samba_4.1.12.bb
>> @@ -39,6 +39,8 @@ SRC_URI[md5sum] = "232016d7581a1ba11e991ec2674553c4"
>>  SRC_URI[sha256sum] = "033604674936bf5c77d7df299b0626052b84a41505a6a6afe902f6274fc29898"
>> 
>>  inherit systemd waf-samba cpan-base perlnative
>> +# remove default added RDEPENDS on perl
>> +RDEPENDS_${PN}_remove = "perl"
> 
> This is a hack, not a solution.

Neither, nor.

> Better to fix this at its core: cpan-base.bbclass forces both DEPENDS_${PN} and RDEPENDS_${PN} to contain "perl".

That's an API / behavior change to cpan-base.bbclass.
Since other recipes rely on that, it's not an easy solution to remove the dependency injection from cpab-base.bbclass.

> All that the recipe really wants to have is the perl version. It does not need a perl for the target, regardless of whether you'd want to install samba-pidl.

Wrong. The recipe wants the perl paths, too.

> Fixing this at the proper level will considerably reduce compilation time for samba, which is already excessively long because of parallel build issues (the patch that fixes that isn't integrated).
> 
>> 
>>  DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd"
>> 
>> @@ -319,4 +321,5 @@ FILES_${PN}-python-dbg = "${libdir}/python${PYTHON_BASEVERSION}/site-packages/.d
>>                            ${libdir}/python${PYTHON_BASEVERSION}/site-packages/samba/dcerpc/.debug/* \
>>  "
>> 
>> +RDEPENDS_${PN}-pidl_append = " perl "
>>  FILES_${PN}-pidl = "${bindir}/pidl ${PERL_VERNDORLIB}/*"
>> --
>> 1.9.1
>> 
>> --
>> Jens Rehsack - rehsack at gmail.com
>> 

Best regards
--
Jens Rehsack - rehsack at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20160105/361e9bb8/attachment-0002.sig>