[oe] [meta-oe][PATCH] CANopenNode: recipe for building the CANopenSocket tools

[Christopher Larson]

On Wed, Jul 13, 2016 at 8:00 AM, Gary Thomas <gary at mlbassoc.com> wrote:

> On 2016-07-13 16:57, cynthiachiu wrote:
>
>> Initial check-in for the CANopenSocket tools recipe.
>>
>> Signed-off-by: cynthiachiu <cynthia.ms.chiu at gmail.com>
>> ---
>>   .../canopennode/canopensocket_git.bb               | 31
>> ++++++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>   create mode 100644 meta-oe/recipes-extended/canopennode/
>> canopensocket_git.bb
>>
>> diff --git a/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>> b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>> new file mode 100644
>> index 0000000..4506698
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/canopennode/canopensocket_git.bb
>> @@ -0,0 +1,31 @@
>> +SUMMARY = "Linux CANOpen tools"
>> +DESCRIPTION = "Linux CANOpen Protocol Stack Tools"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM =
>> "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> +
>> +SRC_URI = "git://github.com/CANopenNode/CANopenSocket.git"
>> +SRCREV = "${AUTOREV}"
>>
>
> Can't you pick a known, working ${REV}?  Using ${AUTOREV} makes it
> impossible
> to use this recipe disconnected from the internet (yes, that's still a
> concern
> in 2016!)
>
>
> +
>> +S = "${WORKDIR}/git"
>> +
>> +do_compile_prepend() {
>> +    cd ${S}
>> +    git submodule init
>> +    git submodule update
>>
>
This fetches things at do_compile time, which is not appropriate. Use
gitsm:// instead of git:// and let the fetcher handle the submodules.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics