[oe] [meta-qt5][krogoth][PATCH] cmake_qt5.bbclass: when using _prepend don't forget to add space at the end

Denys Dmytriyenko denis at denix.org
Thu Jul 28 18:38:30 UTC 2016


On Thu, Jul 28, 2016 at 08:08:35PM +0200, Martin Jansa wrote:
> Is the same needed in master branch?

Yes, just sent separately - had to update commit id, as I used the one from
krogoth below...

-- 
Denys


> On Thu, Jul 28, 2016 at 7:00 PM, Denys Dmytriyenko <denis at denix.org> wrote:
> 
> > From: Denys Dmytriyenko <denys at ti.com>
> >
> > Previous commit aacd63f10dd58acf7bf6138e2f4734e37dcf0420 introduced a bug
> > by
> > using _prepend w/o a space at the end, resulting in corrupted EXTRA_OEMAKE
> > variable in packages that inherit cmake_qt5.bbclass.
> >
> > Signed-off-by: Denys Dmytriyenko <denys at ti.com>
> > ---
> >  classes/cmake_qt5.bbclass | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/classes/cmake_qt5.bbclass b/classes/cmake_qt5.bbclass
> > index 4dc897b..3180fd6 100644
> > --- a/classes/cmake_qt5.bbclass
> > +++ b/classes/cmake_qt5.bbclass
> > @@ -32,4 +32,5 @@ EXTRA_OECMAKE_prepend = " \
> >      -DOE_QMAKE_PATH_QT_DOCS=${OE_QMAKE_PATH_QT_DOCS} \
> >      -DOE_QMAKE_PATH_QT_SETTINGS=${OE_QMAKE_PATH_QT_SETTINGS} \
> >      -DOE_QMAKE_PATH_QT_EXAMPLES=${OE_QMAKE_PATH_QT_EXAMPLES} \
> > -    -DOE_QMAKE_PATH_QT_TESTS=${OE_QMAKE_PATH_QT_TESTS}"
> > +    -DOE_QMAKE_PATH_QT_TESTS=${OE_QMAKE_PATH_QT_TESTS} \
> > +"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel



More information about the Openembedded-devel mailing list