[oe] [PATCH] opencv: Fix broken deps for opencv meta package

[Stiffler, Jacob]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org
> [mailto:openembedded-devel-bounces at lists.openembedded.org] On
> Behalf Of Burton, Ross
> Sent: Wednesday, May 04, 2016 3:35 PM
> To: OpenEmbedded Devel List
> Subject: Re: [oe] [PATCH] opencv: Fix broken deps for opencv meta package
> 
> On 4 May 2016 at 16:15, Jacob Stiffler <j-stiffler at ti.com> wrote:
> 
> > * The opencv meta package's RDEPENDS list is blindly populated with
> >   all non *-dev, *-dbg, and *-doc packages
> >
> > * This includes the non-existent opencv-locale package which is added
> >   to the list by default in oe-core/meta/conf/bitbake.conf
> > * This issue was hidden as late as jethro as the distutils class was
> >   overwriting the PACKAGES list
> > * Therefore add opencv-locale to the opencv meta package blacklist,
> >   and filter out all packages which contain "locale" in the package
> >   name to be safe.
> >
> > * Another issue with the meta package dependency generation logic is
> >   that it may add other empty, non-existent packages.
> > * The existence of the opencv-java package depends on the
> >   PACKAGECONFIG, though it is added as a meta package dependency in
> >   all cases.
> > * Therefore check the contents of PKGDEST to only add non-empty
> >   packages as RDEPENDS for the opencv meta package.
> >
> 
> do_split_packages() returns the list of packages that it created, so the
> output from the final call to do_split_packages (that creates lib%s) should
> be exactly what you need to create a metapackage.
>

The problem this patch is resolving does not involve do_split_packages. 

The problem is that the PACKAGES list and the packages created are different since empty packages will not be created by default. For opencv, the PACKAGES list is initialized with non-existent packages such as opencv-locale. The logic which constructs the meta package dependencies will add the non-existent opencv-locale package. Adding non-existent packages to the RDEPENDS means that the meta package has broken dependencies.

> (it currently returns duplicates if multiple files are packages, but this
> doesn't cause a problem for metapackage dependencies)
> 
> Ross
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel