[oe] [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.

[Ahsan, Noor]

Doesn't recipe name is mentioned when only that recipe is changed in the patch. I though when multiple recipes are changed then we don't mention the name of the files in the commit summary. Correct me if my interpretation is wrong.

Secondly I thought both are inter related. That is why added both in signed patch. Farsight is mentioned in the details 

Remove PNBLACKLIST for libnice and farsight recipes.

Noor

-----Original Message-----
From: openembedded-devel-bounces at lists.openembedded.org [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of Christopher Larson
Sent: Thursday, May 05, 2016 10:05 PM
To: Openembedded Discussion
Subject: Re: [oe] [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.

On Thu, May 5, 2016 at 9:22 AM, Noor, Ahsan <noor_ahsan at mentor.com> wrote:

> From: Noor Ahsan <noor_ahsan at mentor.com>
>
> * Update do_compile_append where it was updating *.pc from ${S} and
>   removing staging dir folder. Now we have seperate build folder
>   where packages got build. We have to search pc in ${B} not in ${S}.
>   After updating the tmp dir pathc is removed from nice.pc file.
> * Remove PNBLACKLIST for libnice and farsight recipes.
>
> Signed-off-by: Noor Ahsan <noor_ahsan at mentor.com>
>

The commit message doesn't meet the OE guidelines (not prefixed by the recipe being changed) and you don't mention farsight2 in the message at all
-- should that be a separate commit?
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel at lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel