[oe] [meta-oe][PATCH 1/6] mg: stop relying on make -e

Christopher Larson kergoth at gmail.com
Tue May 17 16:10:15 UTC 2016


From: Christopher Larson <chris_larson at mentor.com>

Relying on 'make -e' isn't ideal, as it's less implicit behavior, relies on
variable exports, and hides the variables being used from someone reading the
recipe.

Signed-off-by: Christopher Larson <chris_larson at mentor.com>
---
 meta-oe/recipes-support/mg/mg_20110905.bb | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/mg/mg_20110905.bb b/meta-oe/recipes-support/mg/mg_20110905.bb
index e924bbd..95aeb62 100644
--- a/meta-oe/recipes-support/mg/mg_20110905.bb
+++ b/meta-oe/recipes-support/mg/mg_20110905.bb
@@ -11,7 +11,17 @@ SRC_URI = "http://homepage.boetes.org/software/mg/mg-${PV}.tar.gz \
 SRC_URI[md5sum] = "2de35316fa8ebafe6003efaae70b723e"
 SRC_URI[sha256sum] = "1cd37d7e6a3eecc890a5718c38b8f38495057ba93856762a756ccee2f9618229"
 
-EXTRA_OEMAKE = "-e MAKEFLAGS="
+# CFLAGS isn't in EXTRA_OEMAKE, as the makefile picks it up via ?=
+EXTRA_OEMAKE = "\
+    'CC=${CC}' \
+    'LDFLAGS=${LDFLAGS}' \
+    \
+    'prefix=${prefix}' \
+    'bindir=${bindir}' \
+    'libdir=${libdir}' \
+    'includedir=${includedir}' \
+    'mandir=${mandir}' \
+"
 
 do_configure () {
     sed -i Makefile.in -e 's,^prefix=.*,prefix=${prefix},'
-- 
2.8.0




More information about the Openembedded-devel mailing list