[oe] [meta-qt4][PATCH] qt4-embedded: Default to build tslib when touchscreen is defined

[Mike Looijmans]

Having some more experience with it, my suggestion would be to REVERT 
c4671873af5ab6c7d15ca397538f154c11c3486e "qt4-embedded.inc: provide 
PACKAGECONFIG for tslib".

The problem with using MACHINE_FEATURES for building the qt4 libs is that the 
qt4 package becomes machine-specific, and if you're buiding for multiple 
machines (with and without touchscreen), there'll be lots of "setstate" 
activity to take care of that.

Building tslib hardly hurts, it's a small dependency, while building qt4 takes 
something like 5 minutes on our big ass i7 build server. And deciding not to 
install the plugin is quite efficient.

At the very least, "tslib" should be in the default config.

I don't know the rationale behind commit c4671873af5, if reducing compile time 
was the incentive, it's not really paying off. Time would be better spent 
avoiding building "perl" or "bash"...


On 31-10-16 15:12, Max Krummenacher wrote:
> Hi
>
> I sent a similar patch:
> https://lists.yoctoproject.org/pipermail/yocto/2016-October/032661.html
>
> Both fix the build error with the HEAD of meta-qt4.
>
> Question is if "touchscreen" in MACHINE_FEATURES should build for
> tslib by default.
> If yes, your patch is needed.
>
> However the error will pop up again if someone chooses to set
> PACKAGECONFIG to not include tslib.
> That would be handled by the patch above, so applying both patches
> would fix the problem and default to having tslib support.
>
> Max
>
> P.S.What is the 'correct' mailinglist for meta-qt4?
>
> 2016-10-31 8:29 GMT+01:00 Mike Looijmans <mike.looijmans at topic.nl>:
>> When "touchscreen" is in the MACHINE_FEATURES, packagegroup-core-qt4e
>> will RDEPEND on qt4-embedded-plugin-mousedriver-tslib, but that
>> library is not being built by default, resulting in an error like:
>> opkg_prepare_url_for_install: Couldn't find anything to satisfy 'qt4-embedded-plugin-mousedriver-tslib'.
>>
>> To prevent that from happening, add "tslib" to the default
>> PACKAGECONFIG when touchscreen is defined.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans at topic.nl>
>> ---
>> Applies to both morty and master branches.
>>
>>  recipes-qt4/qt4/qt4-embedded.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-qt4/qt4/qt4-embedded.inc b/recipes-qt4/qt4/qt4-embedded.inc
>> index 1122080..9c2d9da 100644
>> --- a/recipes-qt4/qt4/qt4-embedded.inc
>> +++ b/recipes-qt4/qt4/qt4-embedded.inc
>> @@ -3,7 +3,7 @@ DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is
>>  SECTION = "libs"
>>  HOMEPAGE = "http://qt-project.org/"
>>
>> -PACKAGECONFIG ??= ""
>> +PACKAGECONFIG ??= '${@bb.utils.contains("MACHINE_FEATURES", "touchscreen", "tslib", "",d)}'
>>  PACKAGECONFIG[tslib] = " -plugin-mouse-tslib, ,tslib"
>>
>>  QT4EDEPENDS = ""
>> --
>> 1.9.1
>>
>> --
>> 

Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans at topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail





_______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel