[oe] [meta-oe][PATCH] android-tools: fix native build

[Nicolas Dechesne]

On Fri, Oct 21, 2016 at 9:10 AM, Koen Kooi <koen.kooi at linaro.org> wrote:
> +    if [ grep -q "ext4_utils" "${TOOLS}" ] ; then
> +        install -D -p -m0755 ${S}/system/core/libsparse/simg_dump.py ${D}${bindir}/simg_dump
> +        install -D -p -m0755 ${S}/system/extras/ext4_utils/mkuserimg.sh ${D}${bindir}/mkuserimg
> +
> +        install -m0755 ${B}/ext4_utils/ext2simg ${D}${bindir}
> +        install -m0755 ${B}/ext4_utils/ext4fixup ${D}${bindir}
> +        install -m0755 ${B}/ext4_utils/img2simg ${D}${bindir}
> +        install -m0755 ${B}/ext4_utils/make_ext4fs ${D}${bindir}
> +        install -m0755 ${B}/ext4_utils/simg2img ${D}${bindir}
> +        install -m0755 ${B}/ext4_utils/simg2simg ${D}${bindir}
> +    fi
> +
> +    if [ grep -q "adb " "${TOOLS}" ] ; then
> +        install -m0755 ${B}/adb/adb ${D}${bindir}i
> +    fi
> +
> +    if [ grep -q "adbd" "${TOOLS}" ] ; then
> +        install -m0755 ${B}/adbd/adbd ${D}${bindir}
> +        install -D -p -m0644 ${WORKDIR}/android-tools-adbd.service \
> +          ${D}${systemd_unitdir}/system/android-tools-adbd.service
> +    fi
> +
> +    if [ grep -q "fastboot" "${TOOLS}" ] ; then
> +        install -m0755 ${B}/fastboot/fastboot ${D}${bindir}
> +    fi
> +
> +    if [ grep -q "mkbootimg" "${TOOLS}" ] ; then
> +         install -m0755 ${B}/mkbootimg/mkbootimg ${D}${bindir}
> +    fi

sorry to notice that just now.. but how can this work? the 'grep'
statements above are wrong and non functional. I was trying to build
the recipe and noticed that no files get installed. The current
implementation will lead to:

$ grep "ext4_utils" "adb fastboot ext4_utils mkbootimg adbd"
grep: adb fastboot ext4_utils mkbootimg adbd: No such file or directory

Both the target and -native build fails, with target build i end up
with this error

ERROR: android-tools-5.1.1.r37-r0 do_package:
SYSTEMD_SERVICE_android-tools value android-tools-adbd.service does
not exist
ERROR: android-tools-5.1.1.r37-r0 do_package: Function failed:
systemd_populate_packages

I suppose it was tested without systemd , so there was no obvious
error, but the resulting packages were empty..

I also needed to add libcap in DEPENDS, to get the compile task to work.

nico