[oe] [meta-networking][PATCH 2/2 v2] ncp: add v1.2.4

[Khem Raj]

On 11/18/16 2:09 AM, André Draszik wrote:
> On Thu, 2016-11-17 at 09:10 -0800, Khem Raj wrote:
>> On Thu, Nov 17, 2016 at 3:59 AM, André Draszik <git at andred.net> wrote:
>>> On Wed, 2016-11-16 at 09:28 -0800, Khem Raj wrote:
>>>>
>>>> On 11/16/16 1:02 AM, André Draszik wrote:
>>>>> Signed-off-by: André Draszik <git at andred.net>
>>>>> ---
>>>>>  meta-networking/recipes-support/ncp/ncp_1.2.4.bb | 32
>>>>> ++++++++++++++++++++++++
>>>>>  1 file changed, 32 insertions(+)
>>>>>  create mode 100644 meta-networking/recipes-support/ncp/ncp_1.2.4.bb
>>>>>
>>>>> diff --git a/meta-networking/recipes-support/ncp/ncp_1.2.4.bb
>>>>> b/meta-
>>>>> networking/recipes-support/ncp/ncp_1.2.4.bb
>>>>> new file mode 100644
>>>>> index 0000000..7bbaaad
>>>>> --- /dev/null
>>>>> +++ b/meta-networking/recipes-support/ncp/ncp_1.2.4.bb
>>>>> @@ -0,0 +1,32 @@
>>>>> +SUMMARY = "a fast file copy tool for LANs"
>>>>> +DESCRIPTION = "ncp is a utility for copying files in a LAN. It has
>>>>> absolutely no \
>>>>> +security or integrity checking, no throttling, no features, except
>>>>> \
>>>>> +one: you don't have to type the coordinates of your peer."
>>>>> +HOMEPAGE = "http://www.fefe.de/ncp"
>>>>> +LICENSE = "GPLv2"
>>>>> +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-
>>>>> licenses/GPL-
>>>>> 2.0;md5=801f80980d171dd6425610833a22dbe6"
>>>>> +DEPENDS = "libowfat"
>>>>> +
>>>>> +SRC_URI = "https://dl.fefe.de/${BP}.tar.bz2"
>>>>> +SRC_URI[md5sum] = "421c4855bd3148b7d0a4342942b4bf13"
>>>>> +SRC_URI[sha256sum] =
>>>>> "6cfa72edd5f7717bf7a4a93ccc74c4abd89892360e2e0bb095a73c24b9359b88"
>>>>> +
>>>>> +EXTRA_OEMAKE = "\
>>>>> +    DIET= \
>>>>> +    DEBUG=nostrip \
>>>>> +    CC='${CC}' CFLAGS='${CFLAGS} -I${STAGING_INCDIR}/libowfat'
>>>>> LDFLAGS='${LDFLAGS}' \
>>>>> +"
>>>>
>>>> Is setting CC etc. on make cmdline really needed ?
>>>
>>> Yes, the Makefile sets CC CFLAGS LDFLAGS excplicitly, so make doesn't
>>> inherit them from the environment variables, because OE doesn't pass the
>>> -e
>>> make flag anymore. https://www.gnu.org/software/make/manual/html_node/En
>>> viro
>>> nment.html#Environment
>>>
>>>> may be just adding the -I flags to CPPFLAGS is enough ?
>>>
>>> It doesn't respect CPPFLAGS, but an alternative would be:
>>>
>>> EXTRA_OEMAKE = "\
>>>     DIET= \
>>>     DEBUG=nostrip \
>>>     -e \
>>> "
>>> CFLAGS_append = " -I${STAGING_INCDIR}/libowfat"
>>
>> Thats seems better.
> 
> I am not sure I agree. This means one could accidentally override make
> variables. Being explicit as in the original version is more deterministic.
> Otherwise somebody would have to audit each recipe's makefile once a
> variable is added or removed from the bitbake environment. That doesn't
> scale. It would appear that the -e flag was removed from EXTRA_OEMAKE in rev
> aeb653861a0ec39ea7a014c0622980edcbf653fa for a similar reason... Even the
> make manual recommends against using -e.

-e is bad for some reason It missed my eye last time so I agree on -e part
my suggestion was mainly on CC and CFLAGS being passed in makefile options
it seems the package Make infra needs a patch for this to work cleanly.

> 
> 
> Andre'
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20161118/39189191/attachment-0002.sig>