[oe] [meta-networking][PATCH] samba: fix the hardcoded path in init script
Koen Kooi
koen at dominion.thruhere.net
Thu Nov 24 10:40:09 UTC 2016
Op 24-11-16 om 06:57 schreef jackie.huang at windriver.com:
> From: Jackie Huang <jackie.huang at windriver.com>
>
> Replace the hardcoded path with base_bindir in init script to fix the
> error: /etc/init.d/samba.sh: line 15: /usr/bin/ps: No such file or
> directory /etc/init.d/samba.sh: line 17: /usr/bin/sed: No such file or
> directory /etc/init.d/samba.sh: line 16: /usr/bin/grep: No such file or
> directory
>
> Signed-off-by: Jackie Huang <jackie.huang at windriver.com> ---
> meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 1 + 1 file
> changed, 1 insertion(+)
>
> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb index
> e9694d4..6c1e3ef 100644 ---
> a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +++
> b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb @@ -111,6
> +111,7 @@ do_install_append() { -e
> 's,/opt/samba/smb.conf,${sysconfdir}/samba/smb.conf,g' \ -e
> 's,/opt/samba/log,${localstatedir}/log/samba,g' \ -e
> 's,/etc/init.d/samba.server,${sysconfdir}/init.d/samba.sh,g' \ +
> -e 's,/usr/bin,${base_bindir},g' \ -i ${D}${sysconfdir}/init.d/samba.sh
> fi
Wouldn't it be better to completely remove the absolute paths?
More information about the Openembedded-devel
mailing list