[oe] [meta-networking][PATCH v2] phytool: Add recipe

[Mike Looijmans]

On 05-10-16 18:32, Martin Jansa wrote:
> On Wed, Oct 05, 2016 at 08:38:07AM -0700, Khem Raj wrote:
>> On Wed, Oct 5, 2016 at 2:34 AM, Mike Looijmans <mike.looijmans at topic.nl> wrote:
>>> A nice tool to directly read, write and interpret ethernet PHY data.
>>> Very useful when debugging PHY or MDIO problems, which ethtool does
>>> not do.
>>>
>>> Signed-off-by: Mike Looijmans <mike.looijmans at topic.nl>
>>> ---
>>> v2: Fix LICENSE filename and checksum
>>>     Honor LDFLAGS value (patch accepted upstream)
>>>
>>>  meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>  create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
>>>
>>> diff --git a/meta-networking/recipes-support/phytool/phytool.bb b/meta-networking/recipes-support/phytool/phytool.bb
>>> new file mode 100644
>>> index 0000000..d451aa9
>>> --- /dev/null
>>> +++ b/meta-networking/recipes-support/phytool/phytool.bb
>>> @@ -0,0 +1,14 @@
>>> +SUMMARY = "PHY interface tool for Linux"
>>> +LICENSE = "GPLv2"
>>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0"
>>> +
>>> +PV = "1.0.1"
>>
>> perhaps its better to include SRCPV in PV above since the SRCREV
>> below is really 1.0.1+some more commits. moreover we get srcrev
>> accounted for task hashes

Will do.

>>
>>> +SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2"
>>> +SRC_URI = "git://github.com/wkz/phytool.git"
>>> +
>>> +S = "${WORKDIR}/git"
>>> +
>>> +do_install() {
>>> +       install -d ${D}${prefix}/bin
>>> +       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
>
> We're not using tabs for indentation.
> see http://www.openembedded.org/wiki/Styleguide

Will fix in v3.

I also want to move it to another location in meta-oe, because meta-networking 
depends on meta-python and it's really weird to have to add meta-python to 
your layers just to get a simple C binary tool.

Mike.


Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans at topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail