[oe] [meta-oe][PATCH] postgresql.inc: Fix do_configure error (could not find Python.h)

[Gary Thomas]

On 2016-10-16 14:15, Mario Domenech Goulart wrote:
> Fixes:
>
> | checking for Python.h... no
> | configure: error: header file <Python.h> is required for Python
> | NOTE: The following config.log files may provide further information.
> | WARNING: exit code 1 from a shell command.
> | NOTE: .../tmp/work/armv5e-poky-linux-gnueabi/postgresql/9.4.8-r0.0/build/config.log
> | ERROR: configure failed
>
> Signed-off-by: Mario Domenech Goulart <mario.goulart at gmail.com>
> ---
>  meta-oe/recipes-support/postgresql/postgresql.inc | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/meta-oe/recipes-support/postgresql/postgresql.inc b/meta-oe/recipes-support/postgresql/postgresql.inc
> index 9592c79..454624c 100644
> --- a/meta-oe/recipes-support/postgresql/postgresql.inc
> +++ b/meta-oe/recipes-support/postgresql/postgresql.inc
> @@ -40,6 +40,8 @@ export LDFLAGS_SL = "${LDFLAGS}"
>
>  inherit autotools pkgconfig perlnative pythonnative useradd update-rc.d systemd
>
> +CFLAGS += "-I${STAGING_INCDIR}/${PYTHON_DIR}"
> +
>  SYSTEMD_SERVICE_${PN} = "postgresql.service"
>  SYSTEMD_AUTO_ENABLE_${PN} = "disable"
>
> @@ -109,12 +111,6 @@ python populate_packages_prepend() {
>  }
>
>  do_configure() {
> -    # do_configure_prepend
> -    # make sure configure finds python includdirs with these envs
> -    export \
> -           STAGING_INCDIR=${STAGING_INCDIR} \
> -           STAGING_LIBDIR=${STAGING_LIBDIR}
> -
>      # do_configure
>      autotools_do_configure
>
>

Why is this needed?  I just built the existing recipe in a bare build
without any problems.  Perhaps I'm missing something?

Also, would it not be better to just add python to DEPENDS?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------