[oe] [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64

[Christopher Larson]

On Fri, Oct 28, 2016 at 3:07 AM, <ting.liu at nxp.com> wrote:

> xterm installs files into PREFIX/lib/X11/app-defaults by default.
> This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
> ERROR: QA Issue: xterm: Files/directories were installed but not shipped
> in any package:
>   /usr/lib
>   /usr/lib/X11
>   /usr/lib/X11/app-defaults
>   /usr/lib/X11/app-defaults/UXTerm
>   /usr/lib/X11/app-defaults/KOI8RXTerm-color
>   /usr/lib/X11/app-defaults/XTerm-color
>   /usr/lib/X11/app-defaults/UXTerm-color
>   /usr/lib/X11/app-defaults/KOI8RXTerm
>   /usr/lib/X11/app-defaults/XTerm
>
> Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to
> configure.
>
> Signed-off-by: Ting Liu <ting.liu at nxp.com>
> ---
>  meta-oe/recipes-graphics/xorg-app/xterm_325.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> index e0baf3c..48556c7 100644
> --- a/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> +++ b/meta-oe/recipes-graphics/xorg-app/xterm_325.bb
> @@ -14,6 +14,7 @@ PACKAGECONFIG[xft] = "--enable-freetype,--disable-freetype,libxft
> fontconfig fre
>
>  EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
>                   --x-libraries=${STAGING_LIBDIR} \
> +                 --with-app-defaults=${libdir}/X11/app-defaults \
>                   FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config
> \
>                   --disable-imake \
>                   --disable-rpath-hack \
>

Are you sure this is correct? I highly doubt those files are actually
multilib specific. Would it not be better to just package these files in
their current location?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics