[oe] [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF

[Martin Jansa]

On Thu, Sep 08, 2016 at 01:10:48PM +0800, jackie.huang at windriver.com wrote:
> From: Jackie Huang <jackie.huang at windriver.com>
> 
> Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
> because the PACKAGECONFIG will not be handled for all recipes after
> the following commit in oe-core:
> 
> commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
> Author: Martin Jansa <martin.jansa at gmail.com>
> Date:   Tue Aug 30 16:19:58 2016 +0200
> 
>     base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in autotools.bbclass
> 
>     * recipes which don't inherit autotools or cmake bbclass and want to
>       use the configure options from PACKAGECONFIG need to handle
>       PACKAGECONFIG_CONFARGS themselves.
> 
>     Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
>     Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> 
> Signed-off-by: Jackie Huang <jackie.huang at windriver.com>
> ---
>  meta-networking/classes/waf-samba.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-samba.bbclass
> index 772bc75..a58ca2c 100644
> --- a/meta-networking/classes/waf-samba.bbclass
> +++ b/meta-networking/classes/waf-samba.bbclass
> @@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
>                    --mandir=${mandir} \
>                  "
>  
> +EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"

Cannot we append it to CONFIGUREOPTS and remove EXTRA_OECONF from this
bbclass completely?

> +
>  # Three methods for waf cross compile:
>  # 1. answers:
>  #    Only --cross-answers - try the cross-answers file, and if
> -- 
> 2.7.4
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20160908/0c61ce33/attachment-0002.sig>