[oe] [meta-networking][PATCH] waf-samba.bbclass: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org [mailto:openembedded-devel-
> bounces at lists.openembedded.org] On Behalf Of Khem Raj
> Sent: Friday, September 09, 2016 9:25 AM
> To: openembeded-devel
> Subject: Re: [oe] [meta-networking][PATCH] waf-samba.bbclass: Append
> PACKAGECONFIG_CONFARGS to EXTRA_OECONF
> 
> On Thu, Sep 8, 2016 at 6:18 PM, Huang, Jie (Jackie)
> <Jackie.Huang at windriver.com> wrote:
> >
> >
> >> -----Original Message-----
> >> From: openembedded-devel-bounces at lists.openembedded.org [mailto:openembedded-devel-
> >> bounces at lists.openembedded.org] On Behalf Of Martin Jansa
> >> Sent: Thursday, September 08, 2016 4:40 PM
> >> To: openembedded-devel at lists.openembedded.org
> >> Subject: Re: [oe] [meta-networking][PATCH] waf-samba.bbclass: Append
> >> PACKAGECONFIG_CONFARGS to EXTRA_OECONF
> >>
> >> On Thu, Sep 08, 2016 at 01:10:48PM +0800, jackie.huang at windriver.com wrote:
> >> > From: Jackie Huang <jackie.huang at windriver.com>
> >> >
> >> > Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF for waf-samba.bbclass
> >> > because the PACKAGECONFIG will not be handled for all recipes after
> >> > the following commit in oe-core:
> >> >
> >> > commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
> >> > Author: Martin Jansa <martin.jansa at gmail.com>
> >> > Date:   Tue Aug 30 16:19:58 2016 +0200
> >> >
> >> >     base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in
> >> autotools.bbclass
> >> >
> >> >     * recipes which don't inherit autotools or cmake bbclass and want to
> >> >       use the configure options from PACKAGECONFIG need to handle
> >> >       PACKAGECONFIG_CONFARGS themselves.
> >> >
> >> >     Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> >> >     Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> >> >
> >> > Signed-off-by: Jackie Huang <jackie.huang at windriver.com>
> >> > ---
> >> >  meta-networking/classes/waf-samba.bbclass | 2 ++
> >> >  1 file changed, 2 insertions(+)
> >> >
> >> > diff --git a/meta-networking/classes/waf-samba.bbclass b/meta-networking/classes/waf-
> >> samba.bbclass
> >> > index 772bc75..a58ca2c 100644
> >> > --- a/meta-networking/classes/waf-samba.bbclass
> >> > +++ b/meta-networking/classes/waf-samba.bbclass
> >> > @@ -20,6 +20,8 @@ CONFIGUREOPTS = " --prefix=${prefix} \
> >> >                    --mandir=${mandir} \
> >> >                  "
> >> >
> >> > +EXTRA_OECONF_append = " ${PACKAGECONFIG_CONFARGS}"
> >>
> >> Cannot we append it to CONFIGUREOPTS and remove EXTRA_OECONF from this
> >> bbclass completely?
> >
> > Yes, we can, but why do we need to remove EXTRA_OECONF from this bbclass
> > completely? Is it going to be deprecated?
> >
> > And I see that EXTRA_OECONF  is used in several recipes that inherit waf-samba,
> > If it's remove from the bbclass, it's should also be removed from those recipes, right?
> >
> 
> EXTRA_OECONF is usually kept for recipe namespace.

Ok, so I will change to use CONFIGUREOPTS in the bbclass.

Thanks,
Jackie

> 
> > Thanks,
> > Jackie
> >
> >>
> >> > +
> >> >  # Three methods for waf cross compile:
> >> >  # 1. answers:
> >> >  #    Only --cross-answers - try the cross-answers file, and if
> >> > --
> >> > 2.7.4
> >> >
> >> > --
> >> > _______________________________________________
> >> > Openembedded-devel mailing list
> >> > Openembedded-devel at lists.openembedded.org
> >> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>
> >> --
> >> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel