[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only

[Mark Asselstine]

On Sunday, September 11, 2016 9:26:44 PM EDT Huang, Jie (Jackie) wrote:
> > -----Original Message-----
> > From: openembedded-devel-bounces at lists.openembedded.org
> > [mailto:openembedded-devel- bounces at lists.openembedded.org] On Behalf Of
> > Joe MacDonald
> > Sent: Saturday, September 10, 2016 8:35 AM
> > To: openembedded-devel at lists.openembedded.org
> > Subject: Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the
> > blacklist to ARM only
> > 
> > [Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to
> > ARM only] On 16.09.10 (Sat> 
> > 00:03) Andreas Müller wrote:
> > > On Fri, Sep 9, 2016 at 10:44 PM, Joe MacDonald 
<Joe_MacDonald at mentor.com> wrote:
> > > > [[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to
> > > > ARM only] On 16.09.09 (Fri> 
> > 10:34) jackie.huang at windriver.com wrote:
> > > >> From: Jackie Huang <jackie.huang at windriver.com>
> > > >> 
> > > >> It builds fine except for arm now, and the do_package
> > > >> and libpam issue is fixed by:
> > > >> "waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS"
> > > > 
> > > > Did you confirm that you're still seeing the failure for arm?
> > > > 
> > > > -J.
> > > > 
> > > >> Signed-off-by: Jackie Huang <jackie.huang at windriver.com>
> > > >> ---
> > > >> 
> > > >>  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++---
> > > >>  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >> 
> > > >> diff --git
> > > >> a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-> 
> > networking/recipes-connectivity/samba/samba_4.4.5.bb
> > 
> > > >> index 042203e..c34adcb 100644
> > > >> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> > > >> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> > > >> @@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl"
> > > >> 
> > > >>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
> > > >>  
> > > >>  # http://errors.yoctoproject.org/Errors/Details/81004/
> > > >> 
> > > >> -# before this issue it was also failing in do_package and
> > > >> -# autodetecting libpam dependency
> > > >> -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new
> > > >> binutils-2.27"
> > > >> +BLACKLIST_REASON ?= ""
> > > >> +BLACKLIST_REASON_arm = "BROKEN: fails to build with new
> > > >> binutils-2.27"
> > > >> +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
> > > >> --
> > > >> 2.8.3
> > > > 
> > > > --
> > > > -Joe MacDonald.
> > > > 
> > > > :wq
> > > 
> > > Did you see [1] - it fixes build for arm.
> > > 
> > > [1] http://lists.openembedded.org/pipermail/openembedded-devel/2016-> > 
> > September/108972.html
> > 
> > I didn't, actually, but I had picked it up in my tree anyway when I
> > scooped up the latest set of changes in master-next.  The reason I was
> > asking was because I wasn't seeing a failure anymore in samba on arm and
> > was curious why Jackie was still seeing it if I wasn't and I hadn't seen
> 
> Actually I never see the failure in:
> http://errors.yoctoproject.org/Errors/Details/81004/
> 
> and I didn't notice Andreas' patch, I was fixing another issue but Mark
> asked me to include the restrict on ARM, please see:
> 
> https://patchwork.openembedded.org/patch/131249/
> 
> so I thought at least Mark was still seeing this and sent this patch.
> 
> Mark, could you confirm that you're still seeing the failure for arm?

I was never able to reproduce the issue but was working on the assumption that 
it was still a real issue, and thus the need to continue to blacklist ARM. if 
the issue no longer exists then the proper thing to do would be to remove the 
blacklist entry and in the commit log which does this, identify what changed 
to remedy the situation. 

Mark


> 
> Thanks,
> Jackie
> 
> > an explicit patch to resolve the issue.  But there it is, mystery
> > solved.  Thanks for the heads-up, Andreas.
> > 
> > --
> > -Joe MacDonald.
> > 
> > :wq