[oe] [meta-java][PATCH v2] xpp3: Fix bashism

Maxin B. John maxin.john at intel.com
Tue Sep 13 13:36:42 UTC 2016


Hi Ricardo,

On Tue, Sep 13, 2016 at 02:37:57PM +0200, Ricardo Ribalda Delgado wrote:
> findpath var must also be fixed on its second occurrence.
>

Good catch, Thanks! 

It seems that the test builder failed to catch this xpp3 specific error (mostly
related to build environment configuration).

> Without this patch:
> 
> ERROR: xpp3-1.1.3.4.O-r0 do_compile: Function failed: do_compile (log
> 		file is located at
> 		/home/ricardo/curro/qt5022/build-qt5022-open/build/tmp/work/all-poky-linux/xpp3/1.1.3.4.O-r0/temp/log.do_compile.14262)
> ERROR: Logfile of failure stored in:
> /home/ricardo/curro/qt5022/build-qt5022-open/build/tmp/work/all-poky-linux/xpp3/1.1.3.4.O-r0/temp/log.do_compile.14262
> Log data follows:
> | DEBUG: Executing shell function do_compile
> | ----------
> | 1. WARNING in src/java/api/org/xmlpull/v1/XmlPullParserException.java
> (at line 11)
> | 	public class XmlPullParserException extends Exception {
> | 	             ^^^^^^^^^^^^^^^^^^^^^^
> | The serializable class XmlPullParserException does not declare a static final serialVersionUID field of type long
> 
> /home/ricardo/curro/qt5022/build-qt5022-open/build/tmp/work/all-poky-linux/xpp3/1.1.3.4.O-r0/temp/run.do_compile.14262:
> Bad substitution
> | WARNING: exit code 2 from a shell command.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda at gmail.com>
> ---
>  recipes-core/xml-commons/xpp3_1.1.3.4.O.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> index f264022ffe60..808a9372338f 100644
> --- a/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> +++ b/recipes-core/xml-commons/xpp3_1.1.3.4.O.bb
> @@ -33,7 +33,7 @@ do_compile() {
>      mkdir -p build-xpath
>  
>      sourcepath="src/java/xpath"
> -    findpath="${sourcepath//:/ }"
> +    findpath=${sourcepath}
>      javac -sourcepath $sourcepath -cp build-oe -d build-xpath `find $findpath -name "*.java"`
>  
>      fastjar -C build-xpath -c -f xpp3-xpath-${PV}.jar .
> -- 
> 2.9.3

Best Regards,
Maxin



More information about the Openembedded-devel mailing list