[oe] [meta-networking][PATCH] phytool: Add recipe

[Khem Raj]

On Sat, Sep 24, 2016 at 8:01 AM, Mike Looijmans <mike.looijmans at topic.nl> wrote:
> On 23-09-16 20:33, Khem Raj wrote:
>>
>> On Fri, Sep 23, 2016 at 5:33 AM, Mike Looijmans <mike.looijmans at topic.nl>
>> wrote:
>>>
>>> A nice tool to directly read, write and interpret ethernet PHY data.
>>> Very useful when debugging PHY or MDIO problems, which ethtool does
>>> not do.
>>>
>>> Signed-off-by: Mike Looijmans <mike.looijmans at topic.nl>
>>> ---
>>>   meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
>>>   1 file changed, 14 insertions(+)
>>>   create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
>>>
>>> diff --git a/meta-networking/recipes-support/phytool/phytool.bb
>>> b/meta-networking/recipes-support/phytool/phytool.bb
>>> new file mode 100644
>>> index 0000000..9d541b7
>>> --- /dev/null
>>> +++ b/meta-networking/recipes-support/phytool/phytool.bb
>>> @@ -0,0 +1,14 @@
>>> +SUMMARY = "PHY interface tool for Linux"
>>> +LICENSE = "GPLv2"
>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>> +
>>> +PV = "1.0.1"
>>> +SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8"
>>> +SRC_URI = "git://github.com/wkz/phytool.git"
>>> +
>>> +S = "${WORKDIR}/git"
>>> +
>>> +do_install() {
>>> +       install -d ${D}${prefix}/bin
>>
>>
>> perhaps use base_bindir here
>
>
> The makefile installs to $PREFIX/bin so I deliberately put the same folder
> in the recipe (the makefile doesn't create the directory). If anyone changes
> $bindir the install will fail.

I see the logic,  if you dont want to use bitbake variables then perhaps its
good to add a comment to explain why it was not done

>
>>
>>> +       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
>>> +}
>>> --
>>> 1.9.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>
> --
> Mike Looijmans
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel