[oe] [PATCH] crash: 7.1.5 -> 7.1.8

[Dengke Du]

On 2017年04月12日 12:03, Peter Kjellerstedt wrote:
>> This patch need to add the "id cc" to HOSTTOOLS in bitbake.conf in
>> oe-core, I will send the patch to oe-core later.
> I doubt you will get either "id" or "cc" accepted into HOSTTOOLS
> in OE-Core. Definitely not "cc" as recipes are expected to use
> ${BUILD_CC} (which uses "gcc") for the host compiler. And probably
Thanks, I find the "cc" come from patch:
     0001-cross_add_configure_option.patch
in ./meta-openembedded/meta-oe/recipes-kernel/crash/crash
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 From cbaaa42933bb27b1bcff4c7d71d54c913201ee88 Mon Sep 17 00:00:00 2001
From: Lei Maohui <leimaohui at cn.fujitsu.com>
Date: Fri, 9 Jan 2015 11:51:18 +0900
Subject: [PATCH] cross_add_configure_option

---
  Makefile | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 9c44633..39bebd0 100644
--- a/Makefile
+++ b/Makefile
@@ -232,7 +232,7 @@ gdb_merge: force
         @echo "../../${PROGRAM} ../../${PROGRAM}lib.a" > 
${GDB}/gdb/mergeobj
         @rm -f ${PROGRAM}
         @if [ ! -f ${GDB}/config.status ]; then \
-         (cd ${GDB}; ./configure ${GDB_CONF_FLAGS} 
--with-separate-debug-dir=/usr/lib/debug \
+         (cd ${GDB}; ./configure --host=${GDB_TARGET} 
--build=${GDB_HOST} --with-separate-debug-dir=/usr/lib/debug \
             --with-bugurl="" --with-expat=no --with-python=no 
--disable-sim; \
           make --no-print-directory CRASH_TARGET=${TARGET}; echo 
${TARGET} > crash.target) \
         else make --no-print-directory rebuild; fi
@@ -277,7 +277,7 @@ force:

  make_configure: force
         @rm -f configure
-       @${CC} ${CONF_FLAGS} -o configure configure.c ${WARNING_ERROR} 
${WARNING_OPTIONS}
+       @cc ${CONF_FLAGS} -o configure configure.c ${WARNING_ERROR} 
${WARNING_OPTIONS}

  clean: make_configure
         @./configure ${CONF_TARGET_FLAG} -q -b
-- 
1.8.4.2
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I will check the above patch now.

The "id" is here:
     https://github.com/crash-utility/crash/blob/master/Makefile#L567

> not "id" unless you have a very good explanation for why it is
> needed. The problem with "id" is that it is typically used to get
> information about the running user, which makes it a problem from
> a deterministic view. Also, since nothing in OE-Core requires "id",
> there is no reason to add it there. It could be added to layer.conf
> in meta-oe, but the concerns about determinism still stands.
>
> //Peter
>
>