[oe] [PATCH V2] crash: 7.1.5 -> 7.1.8

[Anders Darander]

Hi,

* Dengke Du <dengke.du at windriver.com> [170421 12:18]:

> On 2017年04月18日 20:20, Anders Darander wrote:
> > * Dengke Du <dengke.du at windriver.com> [170412 07:42]:

> > > 2. Add the "id" to HOSTTOOLS in meta-oe/layer.conf
> > Why do you need to add `id` to HOSTTOOLS?
> It's not me decide to add "id" to HOSTTOOLS, it's the crash source code
> decides:

> In ./Makefile line 563:
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> release: make_configure
>         @if [ "`id --user`" != "0" ]; then \
>                 echo "make release: must be super-user"; exit 1; fi

How is this going to work? We're not running make as root, thus the
build will fail!?! Or what am I missing?

I'd say, can you try to remove those two lines instead, and see if it
builds correctly?

Besides, are we really running `make release`? I can't find anything
obvious in either the Makefile or the recipe, that calls `make release`.

> > We're normally trying to _increase_ determinism in builds, not reduce
> > it...

I've got really hard time to see why something needs to run `id` in
order to build properly...

Cheers,
Anders

-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB