[oe] [meta-oe][PATCH v2] vlock: add new recipe

Khem Raj raj.khem at gmail.com
Thu Aug 17 02:15:44 UTC 2017


On Wed, Aug 16, 2017 at 6:12 PM, Huang, Jie (Jackie)
<Jackie.Huang at windriver.com> wrote:
>
>
>> -----Original Message-----
>> From: Khem Raj [mailto:raj.khem at gmail.com]
>> Sent: Thursday, August 17, 2017 09:02
>> To: Huang, Jie (Jackie)
>> Cc: openembeded-devel
>> Subject: Re: [oe] [meta-oe][PATCH v2] vlock: add new recipe
>>
>> On Wed, Aug 16, 2017 at 5:48 PM, Huang, Jie (Jackie)
>> <Jackie.Huang at windriver.com> wrote:
>> >
>> >
>> >> -----Original Message-----
>> >> From: Khem Raj [mailto:raj.khem at gmail.com]
>> >> Sent: Thursday, August 17, 2017 01:12
>> >> To: Huang, Jie (Jackie)
>> >> Cc: openembeded-devel
>> >> Subject: Re: [oe] [meta-oe][PATCH v2] vlock: add new recipe
>> >>
>> >> On Tue, Aug 15, 2017 at 10:37 PM,  <jackie.huang at windriver.com> wrote:
>> >> > From: Jackie Huang <jackie.huang at windriver.com>
>> >> >
>> >> > vlock is a program to lock one or more
>> >> > sessions on the Linux console.
>> >> >
>> >> > Signed-off-by: Jackie Huang <jackie.huang at windriver.com>
>> >> > ---
>> >> >  .../vlock/vlock-2.2.3/disable_vlockrc.patch        |  37 +++++++
>> >> >  .../vlock/vlock-2.2.3/vlock-no_tally.patch         | 107
>> >> +++++++++++++++++++++
>> >> >  .../recipes-extended/vlock/vlock-2.2.3/vlock_pam   |   3 +
>> >> >  .../vlock/vlock-2.2.3/vlock_pam_tally2_reset.patch |  19 ++++
>> >> >  meta-oe/recipes-extended/vlock/vlock_2.2.3.bb      |  59 ++++++++++++
>> >> >  5 files changed, 225 insertions(+)
>> >> >  create mode 100644 meta-oe/recipes-extended/vlock/vlock-
>> >> 2.2.3/disable_vlockrc.patch
>> >> >  create mode 100644 meta-oe/recipes-extended/vlock/vlock-2.2.3/vlock-
>> >> no_tally.patch
>> >> >  create mode 100644 meta-oe/recipes-extended/vlock/vlock-
>> 2.2.3/vlock_pam
>> >> >  create mode 100644 meta-oe/recipes-extended/vlock/vlock-
>> >> 2.2.3/vlock_pam_tally2_reset.patch
>> >> >  create mode 100644 meta-oe/recipes-extended/vlock/vlock_2.2.3.bb
>> >> >
>> >> > diff --git a/meta-oe/recipes-extended/vlock/vlock-
>> 2.2.3/disable_vlockrc.patch
>> >> b/meta-oe/recipes-extended/vlock/vlock-2.2.3/disable_vlockrc.patch
>> >> > new file mode 100644
>> >> > index 000000000..ee0d074de
>> >> > --- /dev/null
>> >> > +++ b/meta-oe/recipes-extended/vlock/vlock-2.2.3/disable_vlockrc.patch
>> >> > @@ -0,0 +1,37 @@
>> >> > +Upstream-Status: Inappropriate [configuration]
>> >> > +
>> >> > +written by: Jeff Polk <jeff.polk at windriver.com>
>> >>
>> >> I think a SOB is better than inventing another tag.
>> >
>> > I just follow the guideline:
>> >
>> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Imp
>> orting_from_Elsewhere
>> >
>> > """
>> > It is also necessary to document the original author of the change. You should
>> indicate the original author by simply stating "written by" or "posted to the ...
>> mailing list by". You must not add a Signed-off-by: tag line with their name, only
>> the original author may add their own Signed-off-by: tag line.
>> > """
>> >
>>
>> I wasn't suggesting that you add SOB for someone else. I was suggesting to
>> not have original author attribution so close to the format for
>> Signed-off-by, tested-off-by etc. Something like
>>
>> Original Patch from: < source >
>>
>> where source is publicly listed URL where the patch is posted.
>
> I got the patch from our internal layer and the author is no longer in our company,
> what is the suggesting way if I can't find a public URL for this?
>

you have to consult your company's upstreaming policy.


> Thanks,
> Jackie
>
>>
>>
>> > Thanks,
>> > Jackie



More information about the Openembedded-devel mailing list