[oe] [meta-qt5][PATCH] qtwebengine: disable SECURITY_STRINGFORMAT to fix the build

[Khem Raj]

On Sat, Aug 19, 2017 at 3:33 AM, Martin Jansa <martin.jansa at gmail.com> wrote:
> * meta/conf/distro/include/security_flags.inc adds -Wformat and
>   -Wformat-security, but openh264 adds -Wno-format after that causing
>   build to fail
>
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> ---
>  recipes-qt/qt5/qtwebengine_git.bb | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/recipes-qt/qt5/qtwebengine_git.bb b/recipes-qt/qt5/qtwebengine_git.bb
> index 45b885c..830e640 100644
> --- a/recipes-qt/qt5/qtwebengine_git.bb
> +++ b/recipes-qt/qt5/qtwebengine_git.bb
> @@ -34,6 +34,14 @@ EXTRA_QMAKEVARS_PRE += "GYP_CONFIG+=use_system_yasm \
>  "
>  EXTRA_QMAKEVARS_CONFIGURE += "-feature-system-ninja -no-feature-system-gn"
>
> +# chromium/third_party/openh264/openh264.gyp adds
> +# -Wno-format to openh264_cflags_add
> +# similarly chromium/third_party/openh264/BUILD.gn for newer qtwebengine
> +# causing following error, because -Wformat-security cannot be used together with -Wno-format
> +# cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
> +# http://errors.yoctoproject.org/Errors/Details/150333/
> +SECURITY_STRINGFORMAT = ""
> +

If its not happening in lot of files may be doing something like

 QT_WARNING_PUSH
 QT_WARNING_DISABLE_GCC("-Wformat-security")
#ifdef __clang__
QT_WARNING_DISABLE_CLANG("-Wformat-security")
#endif
....

QT_WARNING_POP

is more targeted as it can be done per file.

>  # To use system ffmpeg you need to enable also libwebp, opus, vpx
>  # Only depenedencies available in oe-core are enabled by default
>  PACKAGECONFIG ??= "libwebp flac libevent libxslt speex nss"
> --
> 2.14.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel