[oe] [meta-oe][PATCH] iproute2: Move append to meta-networking layer

[Fabio Berton]

I agree that is better move libmnl to oe-core, you can abandon this patch
and Yi Zhao patch.

On Mon, Aug 28, 2017 at 10:54 PM, Yi Zhao <yi.zhao at windriver.com> wrote:

>
>
> 在 2017年08月29日 09:48, Mark Hatle 写道:
>
>> On 8/28/17 8:30 PM, Yi Zhao wrote:
>>
>>>
>>> 在 2017年08月29日 09:19, Mark Hatle 写道:
>>>
>>>> On 8/28/17 8:07 PM, Mark Hatle wrote:
>>>>
>>>>> On 8/28/17 1:13 PM, Fabio Berton wrote:
>>>>>
>>>>>> meta-openembedded commit eb8994f44a080d9c7fd2c87b6b6935ad0a55eb27
>>>>>> added
>>>>>> iproute2 append to enable tipc PACKAGECONFIG that install libmnl
>>>>>> package. libmnl recipe is in meta-networking layer and this layer
>>>>>> needs to be added to bblayers.conf file to build libmnl. Move
>>>>>> iproute2 append to meta-networking to allow build iproute2 without add
>>>>>> meta-networking layer to bblayers.conf.
>>>>>>
>>>>> At first I thought this was the right answer.. but the more I look at
>>>>> this, the
>>>>> more issues I find.
>>>>>
>>>>> The iproute2 bbappend modifies the PACKAGECONFIG.  The modification of
>>>>> the
>>>>> PACKAGECONFIG (other then adding new options) should not be done in a
>>>>> bbappend,
>>>>> otherwise it 'changes' the settings for that recipe.
>>>>>
>>>>> I'm thinking the right fix is actually to remove iproute2 bbappend.
>>>>> And any
>>>>> distributions or users who need tipc should enable it themselves
>>>>> within their
>>>>> distribution configuration files (and also include the meta-networking
>>>>> layer) as
>>>>> necessary.
>>>>>
>>>> Sorry to reply to my reply.. but
>>>>
>>>> Simply reverting this ends up with:
>>>>
>>>> ERROR: Nothing RPROVIDES 'iproute2-tipc' (but
>>>> /home/mhatle/git/lpd/master/layers/meta-openembedded/meta-ne
>>>> tworking/recipes-extended/tipcutils/tipcutils_git.bb
>>>> RDEPENDS on or otherwise requires it)
>>>>
>>>> So somehow tipcutils requirement needs to be based on the configuration
>>>> of
>>>> iproute2.  I'm not sure how to do this.
>>>>
>>> Hi Mark,
>>>
>>> The tipcutils 2.2 removed the tipc-config tool and recommended to use
>>> the new configuration tool named "tipc" in iproute2 package for
>>> configuring the tipc.
>>>
>> The problem still remains that the PACKAGECONFIG change violates the Yocto
>> Project compliance check scripts requirement that PACKAGECONFIGs only be
>> set by
>> the original .bb or by a distribution configuration.
>>
>> I agree with the other comments that libmnl should be moved to oe-core
>> (if that
>> is still possible), but the PACKAGECONFIG piece is still a problem that
>> needs to
>> be resolved.
>>
>
> Once the libmnl is moved,  the iproute2 can build tipc directly and no
> need PACKAGECONFIG, we can remove it too.
>
> Yi
>
>
>
>> The tipc in iproute2 needs libmnl as dependency but it is in
>>> meta-networking layer now. so I add this bbappend because we can not
>>> enable tipc build in oe-core directly.
>>> Randy had pointed the best way is move libmnl to oe-core and enable tipc
>>> build in iproute2 by default.
>>>
>>> Yi
>>>
>>> --Mark
>>>>
>>>> --Mark
>>>>>
>>>>> Signed-off-by: Fabio Berton <fabio.berton at ossystems.com.br>
>>>>>> ---
>>>>>>    .../recipes-connectivity/iproute2/iproute2_%.bbappend
>>>>>>          | 0
>>>>>>    1 file changed, 0 insertions(+), 0 deletions(-)
>>>>>>    rename {meta-oe => meta-networking}/recipes-conne
>>>>>> ctivity/iproute2/iproute2_%.bbappend (100%)
>>>>>>
>>>>>> diff --git a/meta-oe/recipes-connectivity/iproute2/iproute2_%.bbappend
>>>>>> b/meta-networking/recipes-connectivity/iproute2/iproute2_%.bbappend
>>>>>> similarity index 100%
>>>>>> rename from meta-oe/recipes-connectivity/iproute2/iproute2_%.bbappend
>>>>>> rename to meta-networking/recipes-connectivity/iproute2/iproute2_%.
>>>>>> bbappend
>>>>>>
>>>>>>
>>
>