[oe] [PATCH] [meta-networking][PATCH] packagegroup-samba: new add
Andreas Oberritter
obi at opendreambox.org
Tue Dec 5 13:29:03 UTC 2017
Hi Zheng,
On Tue, 5 Dec 2017 17:33:07 +0800
zhengrq <zhengrq.fnst at cn.fujitsu.com> wrote:
> Add packagegroup for samba, for there are too many rpms in samba and it's hard to manage.
>
> Signed-off-by: Zheng Ruoqin <zhengrq.fnst at cn.fujitsu.com>
> ---
> .../packagegroups/packagegroup-samba.bb | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 meta-networking/recipes-connectivity/packagegroups/packagegroup-samba.bb
>
> diff --git a/meta-networking/recipes-connectivity/packagegroups/packagegroup-samba.bb b/meta-networking/recipes-connectivity/packagegroups/packagegroup-samba.bb
> new file mode 100644
> index 0000000..6177691
> --- /dev/null
> +++ b/meta-networking/recipes-connectivity/packagegroups/packagegroup-samba.bb
> @@ -0,0 +1,28 @@
> +SUMMARY = "samba package groups"
> +PV = "1.0"
> +PR = "r2"
> +
> +inherit packagegroup
> +
> +PROVIDES = "${PACKAGES}"
> +PACKAGES = "${PN}-server ${PN}-client ${PN}-ctdb-tests ${PN}-pidl"
> +
> +SUMMARY_${PN}-client = " samba client"
> +RDEPENDS_${PN}-client = "\
> + smbclient \
> + samba-common \
> + winbind \
> + registry-tools \
> + "
Why don't you just create a samba-client meta package inside
the samba recipe instead?
> +
> +SUMMARY_${PN}-server = " samba server"
> +RDEPENDS_${PN}-server = "\
> + samba \
> + samba-common \
> + "
All samba libraries already depend on samba-common, so samba depends on it
indirectly. Therefore this "package group" doesn't seem to be necessary.
> +
> +SUMMARY_${PN}-ctdb-tests = " samba ctdb-tests"
> +RDEPENDS_${PN}-ctdb-tests = "samba-ctdb-tests"
> +
> +SUMMARY_${PN}-pidl = "samba-pidl"
> +RDEPENDS_${PN}-pidl = "samba-pidl"
These two seem to be unnecessary, too.
Regards,
Andreas
More information about the Openembedded-devel
mailing list