[oe] [meta-python][rocko][PATCH 2/2] python-twisted: restore RDEPENDS on -news for py2

Derek Straka derek at asterius.io
Fri Dec 15 20:01:42 UTC 2017


That would be useful.  I'm working through automated tests that build every
package into a minimal rootfs and then attempt to perform all of imports to
make sure everything is available for use.  I'm hoping to roll that out in
the next couple of weeks.  Thanks for catching this regression.

On Dec 15, 2017 2:35 PM, "Mark Asselstine" <mark.asselstine at windriver.com>
wrote:

> I work with a lot of python recipes in meta-cloud-services and
> especially the openstack packages have a large number of dependencies.
> Find attached a basic script I have written to help parse
> requirements.txt files. It might help you out with this work.
>
> Anyway, I will send out a V2 with the additional cherrypicks.
>
> On Fri, Dec 15, 2017 at 2:30 PM, Derek Straka <derek at asterius.io> wrote:
> > Yeah.  Agreed.  These commits are me cleaning up the RDEPENDS to work
> with
> > minimal python installs.  Meta-python has been pretty bad about setting
> the
> > dependencies.  I just missed the news package.  Thanks.
> >
> > On Dec 15, 2017 2:22 PM, "Mark Asselstine" <
> mark.asselstine at windriver.com>
> > wrote:
> >
> >> No problem. Unfortunately your commit log was thin on information so I
> >> had to make some assumptions as to what you were doing in the commit.
> >> I could have easily misinterpreted.
> >>
> >> On Fri, Dec 15, 2017 at 2:19 PM, Derek Straka <derek at asterius.io>
> wrote:
> >> > Sure.  I wasn't clear and even then I misread the 1/2 patch and
> thought I
> >> > removed news from core and not the base package RDEPENDS.
> >> >
> >> > On Dec 15, 2017 2:08 PM, "Mark Asselstine" <
> >> mark.asselstine at windriver.com>
> >> > wrote:
> >> >
> >> > The RDEPENDS are not for core, these are RDEPENDS_${PN}, ie. if you
> >> > don't know what parts you want you install ${PN} and get everything.
> >> > We can straighten this up though if my thoughts are incorrect. I have
> >> > to send a V2 anyway as I was hasty and missed the cherrypick of a
> >> > bunch of dependencies you added for automat and others.
> >> >
> >> > Mark
> >> >
> >> > On Fri, Dec 15, 2017 at 1:32 PM, Derek Straka <derek at asterius.io>
> wrote:
> >> >> Is it actually required for core?  I thought I went through and
> verified
> >> >> that news was a stand alone module.
> >> >>
> >> >> On Dec 15, 2017 12:46 PM, "Mark Asselstine" <
> >> mark.asselstine at windriver.com
> >> >>
> >> >> wrote:
> >> >>
> >> >>> Although this plugin has not yet been ported to py3 it is available
> in
> >> >>> py2. The previous commit isn't clear about what is being addressed
> but
> >> >>> I assume it is:
> >> >>>
> >> >>> nothing provides python3-twisted-news needed by
> >> > python3-twisted-17.9.0-r0.
> >> >>> corei7_64
> >> >>>
> >> >>> For py2 this package is valid and so we should maintain the
> RDEPENDS,
> >> >>> restore this RDEPENDS for py2.
> >> >>>
> >> >>> Signed-off-by: Mark Asselstine <mark.asselstine at windriver.com>
> >> >>> ---
> >> >>>  meta-python/recipes-devtools/python/python-twisted_17.9.0.bb | 6
> >> ++++++
> >> >>>  1 file changed, 6 insertions(+)
> >> >>>
> >> >>> diff --git a/meta-python/recipes-devtools/python/python-
> >> twisted_17.9.0.bb
> >> >>> b/meta-python/recipes-devtools/python/python-twisted_17.9.0.bb
> >> >>> index 2be1709..7fc8c65 100644
> >> >>> --- a/meta-python/recipes-devtools/python/python-twisted_17.9.0.bb
> >> >>> +++ b/meta-python/recipes-devtools/python/python-twisted_17.9.0.bb
> >> >>> @@ -2,3 +2,9 @@ inherit pypi setuptools
> >> >>>  require python-twisted.inc
> >> >>>
> >> >>>  RDEPENDS_${PN}-core += "${PYTHON_PN}-contextlib"
> >> >>> +
> >> >>> +# Not yet ported to py3 yet available in py2
> >> >>> +# See src/twisted/python/_setup.py -- notPortedModules
> >> >>> +RDEPENDS_${PN} += "\
> >> >>> +    ${PN}-news \
> >> >>> +    "
> >> >>> --
> >> >>> 2.7.4
> >> >>>
> >> >>> --
> >> >>> _______________________________________________
> >> >>> Openembedded-devel mailing list
> >> >>> Openembedded-devel at lists.openembedded.org
> >> >>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >> >>>
> >> >> --
> >> >> _______________________________________________
> >> >> Openembedded-devel mailing list
> >> >> Openembedded-devel at lists.openembedded.org
> >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >> > --
> >> > _______________________________________________
> >> > Openembedded-devel mailing list
> >> > Openembedded-devel at lists.openembedded.org
> >> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



More information about the Openembedded-devel mailing list