[oe] [meta-qt5][PATCH v6] Upgrade to Qt 5.8

Andreas Müller schnitzeltony at googlemail.com
Tue Feb 7 15:56:21 UTC 2017


On Thu, Jan 26, 2017 at 3:54 PM, Samuli Piippo <samuli.piippo at qt.io> wrote:
> The linux-oe-g++ mkspec is changed to use $$(...) operator to obtain
> the contents of an environment value when qmake is run instead of when
> Makefile is processed. All OE_QMAKE_xxx variables need to be exported
> for qmake to find them. configure's setBootstrapVariable function needs
> to change $$(..) to normal $(...) operator to work with qmake's Makefile.
>
> qt.conf generation for qtbase recipes is not needed, as configure will
> generate its own version based on configure arguments. Skip running
> qmake, since configure is now automatically invoked when it's run in
> qtbase's root folder.
>
> Update PACKAGECONFIGs for qtbase to match current configure options.
>
> The new Qt configuration system [1] can be used with a new variable
> EXTRA_QMAKEVARS_CONFIGURE, which takes both command line and feature
> arguments.
>
> Merge the two qtwayland recipes to one that supports all three targets
> (target, native, nativesdk) without need for additional patch.
>
> Recipes for new Qt modules: QtSCXML, QtNetworkAuth, QtGamepad.
> Removes qtdeclarative-render2d
>
> [1] https://www.mail-archive.com/development@qt-project.org/msg25257.html
>
I have two issues/questions regarding this patch;

1. This patch changes the way qmake finds qt.conf. For 5.7 qmake was
checking if QT_CONF_PATH was set in environment and if so did the
right thing without further quirks. This is gone now and we have to
pass with -qtconf ${OE_QMAKE_QTCONF_PATH}. This causes additional
efforts for packages using qmake from within autotools e.g all the
synth-stuff found at [1]. Is this change really necessary?

2.
>+generate_qt_config_file_effective_paths() {
>+    cat >> ${OE_QMAKE_QTCONF_PATH} <<EOF
>+[EffectivePaths]
>+HostBinaries = ${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}
>+HostData = ${OE_QMAKE_PATH_HOST_DATA}
>+HostPrefix = ${STAGING_DIR_NATIVE}${prefix_native}

^^ This does not look sane to me - shouldn't this be
HostPrefix = ${STAGING_DIR_HOST}${prefix}

Sorry for entering this late but I had other tasks the recent weeks

Andreas

[1] http://www.rncbc.org/drupal/



More information about the Openembedded-devel mailing list