[oe] [meta-oe][PATCH v2 3/3] libwebsockets: Add recipe for version 2.1.0
Andre McCurdy
armccurdy at gmail.com
Wed Feb 8 20:16:50 UTC 2017
On Wed, Feb 8, 2017 at 10:13 AM, Fabio Berton
<fabio.berton at ossystems.com.br> wrote:
> Signed-off-by: Fabio Berton <fabio.berton at ossystems.com.br>
> ---
> .../libwebsockets/libwebsockets_2.1.0.bb | 32 ++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
>
> diff --git a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
> new file mode 100644
> index 000000000..316b38d3b
> --- /dev/null
> +++ b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
> @@ -0,0 +1,32 @@
> +SUMMARY = "Canonical libwebsockets.org websocket library"
> +HOMEPAGE = "https://libwebsockets.org/"
> +LICENSE = "LGPL-2.1"
> +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
GPL-2.0 looks wrong given that LICENSE is LGPL and not GPL?
Define LIC_FILES_CHKSUM in terms of a file from within the
libwebsockets source tree instead.
> +
> +DEPENDS = "zlib"
> +
> +SRC_URI = "https://github.com/warmcat/libwebsockets/archive/v${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "4df3be57dee43aeebd54a3ed56568f50"
> +SRC_URI[sha256sum] = "bcc96aaa609daae4d3f7ab1ee480126709ef4f6a8bf9c85de40aae48e38cce66"
> +
> +S = "${WORKDIR}/${PN}-${PV}"
That's the default, so doesn't need to be specified.
> +inherit cmake pkgconfig
> +
> +PACKAGECONFIG ?= "libuv client server http2 ssl"
> +PACKAGECONFIG[libev] = "-DLWS_WITH_LIBEV=ON,-DLWS_WITH_LIBEV=OFF,libev"
> +PACKAGECONFIG[libuv] = "-DLWS_WITH_LIBUV=ON,-DLWS_WITH_LIBUV=OFF,libuv"
> +PACKAGECONFIG[client] = "-DLWS_WITHOUT_CLIENT=OFF,-DLWS_WITHOUT_CLIENT=ON,"
> +PACKAGECONFIG[server] = "-DLWS_WITHOUT_SERVER=OFF,-DLWS_WITHOUT_SERVER=ON,"
> +PACKAGECONFIG[http2] = "-DLWS_WITH_HTTP2=ON,-DLWS_WITH_HTTP2=OFF,"
> +PACKAGECONFIG[ipv6] = "-DLWS_IPV6=ON,-DLWS_IPV6=OFF,"
> +PACKAGECONFIG[ssl] = "-DLWS_WITH_SSL=ON,-DLWS_WITH_SSL=OFF,openssl"
> +PACKAGECONFIG[testapps] = "-DLWS_WITHOUT_TESTAPPS=OFF,-DLWS_WITHOUT_TESTAPPS=ON,"
Maybe sort this list of PACKAGECONFIG options (unless the current
order has some special significance?).
> +
> +PACKAGES =+ "${PN}-testapps"
> +
> +FILES_${PN}-dev += "${libdir}/cmake/libwebsockets/*.cmake"
The "convention" in various other recipes seems to be simply:
FILES_${PN}-dev += "${libdir}/cmake"
> +FILES_${PN}-testapps += "${datadir}/libwebsockets-test-server/*"
> +
> +RDEPENDS_${PN} += "zlib"
Explicitly defining a runtime dependency on a library isn't normally
required since it will be detected automatically. If it is required in
this case then please explain why in the commit message.
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
More information about the Openembedded-devel
mailing list