[oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency

[Tom Hochstein]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org [mailto:openembedded-devel-bounces at lists.openembedded.org] On
> Behalf Of Samuli Piippo
> Sent: Thursday, February 09, 2017 2:39 AM
> To: openembedded-devel at lists.openembedded.org
> Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency
> 
> In 5.8 (master), there is now a "system-assimp" PACKAGECONFIG option
> that correctly enables/disables assimp dependency.
> 
> >>>> fatal error: assimp/Importer.hpp: No such file or directory
> 
> Is this really a fatal build error or a config test error?
> In case qt3d doesn't find system assimp, it will use its internal copy
> of it.

As I remember it was a build error, but unfortunately I don't have the surrounding error text to confirm this and cannot reproduce the error.

> 
> 
> On 02/08/2017 09:43 PM, Martin Jansa wrote:
> > RSS:
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.openembedded.org%2Fopenembedded-
> core%2Fcommit%2F%3Fid%3D809746f56df4b91af014bf6a3f28997d6698ac78&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04
> 444d8432f897808d450c73559%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=slwG0AloaQo4oRoDA3GHD6BmPdQ7bzw02GkRJHlp
> aWQ%3D&reserved=0
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fpipermail%2Fopenembedded-
> architecture%2F2017-
> January%2F000384.html&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04444d8432f897808d450c73559%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0&sdata=NL7A%2B0Dj6Mgt4osVT10RGZM3Iz0jpLzTwQemNqD%2BYgA%3D&reserved=0
> > and following threads
> >
> > For morty and older releases you need to disable autodetection in qt3d
> > sources when the assimp PACKAGECONFIG is not enabled (see PACKAGECONFIG in
> > other recipes for some examples how to do it - but for qt5 it's often
> > tricky as it rarely has enable/disable options usable in configure and has
> > to be patched).
> >
> > Otherwise assimp can still be detected when it's built as a dependency of
> > some other recipe and might be removed from sysroot while qt3d build is
> > already running and causing the issues you were trying to fix.
> >
> > On Wed, Feb 8, 2017 at 6:42 PM, Tom Hochstein <tom.hochstein at nxp.com> wrote:
> >
> >>
> >>
> >>> -----Original Message-----
> >>> From: openembedded-devel-bounces at lists.openembedded.org [mailto:
> >> openembedded-devel-bounces at lists.openembedded.org] On
> >>> Behalf Of Martin Jansa
> >>> Sent: Tuesday, February 07, 2017 6:01 AM
> >>> To: openembedded-devel at lists.openembedded.org
> >>> Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency
> >>>
> >>> On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:
> >>>> Fix build error:
> >>>>
> >>>> fatal error: assimp/Importer.hpp: No such file or directory
> >>>
> >>> I'm was able to build qt3d without this dependency, is there something
> >>> in your config which enabled it? Or is it autodetected from sysroot
> >>> which wont be an issue anymore with master and RSS, but your change
> >>> doesn't fix the autodetection for older branches.
> >>
> >> We do enable assimp from another recipe.
> >>
> >> I am unable to reproduce the original problem either.
> >>
> >> Without the explicit dependency, it would seem that the build would at
> >> best be non-deterministic, enabling or disabling assimp support based
> >> solely on the timing of the Yocto tasks. I'm not aware of the technologies
> >> you allude to. Do they provide some determinism for this case?
> >>
> >>>
> >>>> Signed-off-by: Tom Hochstein <tom.hochstein at nxp.com>
> >>>> ---
> >>>>  recipes-qt/qt5/qt3d_git.bb | 1 +
> >>>>  1 file changed, 1 insertion(+)
> >>>>
> >>>> diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
> >>>> index 2276c36..7c31213 100644
> >>>> --- a/recipes-qt/qt5/qt3d_git.bb
> >>>> +++ b/recipes-qt/qt5/qt3d_git.bb
> >>>> @@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
> >>>>  PACKAGECONFIG_class-native ??= "tools-only"
> >>>>  PACKAGECONFIG_class-nativesdk ??= "tools-only"
> >>>>  PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
> >>>> +PACKAGECONFIG[assimp] = ",,assimp"
> >>>>
> >>>>  EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
> >>>>
> >>>> --
> >>>> 1.9.1
> >>>>
> >>>> --
> >>>> _______________________________________________
> >>>> Openembedded-devel mailing list
> >>>> Openembedded-devel at lists.openembedded.org
> >>>>
> >>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.
> >> openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
> >>> d-
> >>> devel&data=01%7C01%7Ctom.hochstein%40nxp.com%
> >> 7Cfa462298ac744a52797808d44f50f020%7C686ea1d3bc2b4c6fa92cd99c5c301635
> >>> %7C0&sdata=mLf9Lt9hQ5Rn8Ygbq7PczLY4Ix%2BscnMCbhC%2BDyUwLLM%3D&reserved=0
> >>>
> >>> --
> >>> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel at lists.openembedded.org
> >>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
> d-
> devel&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04444d8432f897808d450c73559%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0&sdata=gs5n%2FZqFAO8HLTQOrOi4nql3wTRykYUUhM9BCGb9sRY%3D&reserved=0
> >>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
> d-
> devel&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04444d8432f897808d450c73559%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0&sdata=gs5n%2FZqFAO8HLTQOrOi4nql3wTRykYUUhM9BCGb9sRY%3D&reserved=0