[oe] [meta-oe][PATCH] libmikmod: create packageconfig option for pulseaudio

[Andreas Oberritter]

On Thu, 16 Feb 2017 11:42:43 +0100
Andreas Müller <schnitzeltony at googlemail.com> wrote:

> On Thu, Feb 16, 2017 at 11:36 AM, Andreas Oberritter
> <obi at opendreambox.org> wrote:
> > Signed-off-by: Andreas Oberritter <obi at opendreambox.org>
> > ---
> >  meta-oe/recipes-multimedia/mikmod/libmikmod_3.3.6.bb | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-multimedia/mikmod/libmikmod_3.3.6.bb b/meta-oe/recipes-multimedia/mikmod/libmikmod_3.3.6.bb
> > index 2e1b9bf..9d31c92 100644
> > --- a/meta-oe/recipes-multimedia/mikmod/libmikmod_3.3.6.bb
> > +++ b/meta-oe/recipes-multimedia/mikmod/libmikmod_3.3.6.bb
> > @@ -3,7 +3,7 @@ SECTION = "libs"
> >  LICENSE = "LGPLv2.1"
> >  LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
> >
> > -DEPENDS = "alsa-lib texinfo pulseaudio"
> > +DEPENDS = "alsa-lib texinfo"
> >
> >  SRC_URI = "\
> >      ${SOURCEFORGE_MIRROR}/project/mikmod/${BPN}/${PV}/${BPN}-${PV}.tar.gz \
> > @@ -24,3 +24,5 @@ EXTRA_OECONF = "\
> >      --enable-threads \
> >  "
> >
> > +PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)}"
> > +PACKAGECONFIG[pulseaudio] = "--enable-pulseaudio,--disable-pulseaudio,pulseaudio"
> > --  
> Does pulseaudio do something useful without pulseaudio-server in the
> image? Something like
> 
> PACKAGECONFIG[pulseaudio] =
> "--enable-pulseaudio,--disable-pulseaudio,pulseaudio,pulseaudio-server"

I have no idea, because I never used pulseaudio. This patch just tries to
fix a broken dependency chain for another recipe depending on libmikmod.

FWIW, I guess you could include pulseaudio support in libmikmod without
forcing its use, so adding a runtime dependency on the server seems to be
a bit too much.

Regards,
Andreas