[oe] [PATCH][meta-browser] chromium: add i586 (qemux86) support

[Trevor Woerner]

On Sat 2016-12-31 @ 10:32:47 AM, Khem Raj wrote:
> On Fri, Dec 30, 2016 at 10:11 AM, Trevor Woerner <twoerner at gmail.com> wrote:
> > Build and run tested on qemux86 (i586) and turbot (x86-64).
> >
> > Signed-off-by: Trevor Woerner <twoerner at gmail.com>
> > ---
> >  recipes-browser/chromium/chromium_52.0.2743.76.bb |  2 ++
> >  recipes-browser/chromium/files/i586/x86-m32.patch | 42 +++++++++++++++++++++++
> >  2 files changed, 44 insertions(+)
> >  create mode 100644 recipes-browser/chromium/files/i586/x86-m32.patch
> >
> > diff --git a/recipes-browser/chromium/chromium_52.0.2743.76.bb b/recipes-browser/chromium/chromium_52.0.2743.76.bb
> > index 5be3c32..bba1549 100644
> > --- a/recipes-browser/chromium/chromium_52.0.2743.76.bb
> > +++ b/recipes-browser/chromium/chromium_52.0.2743.76.bb
> > @@ -14,6 +14,8 @@ SRC_URI += "\
> >          ${@bb.utils.contains('PACKAGECONFIG', 'ignore-lost-context', 'file://0001-Remove-accelerated-Canvas-support-from-blacklist.patch', '', d)} \
> >  "
> >
> > +SRC_URI_append_i586 = "file://x86-m32.patch"
> > +
> 
> it this 32bit x86 specific or i586 specific ? If its former then using
> x86 override would be more
> appropriate.

I don't have any 32-bit x86 hardware on which to test so I built and tested
this for qemux86. qemux86 uses i586 for its tuning, so I targeted the append
for this configuration.

To me "i586", "i686", and "x86" are synonymous; they all mean intel/amd 32-bit
;-)

> secondly, what does removing -m32 fix ? I thought it would
> just be nop in case of
> 32bit

Like Martin pointed out, having these in are what is causing the builds to
fail. Without this patch the do_compile fails with 5 such similar errors:

	| FAILED: obj.host/third_party/icu/source/common/icuuc.servlk.o
	| g++  -MMD -MF obj.host/third_party/icu/source/common/icuuc.servlk.o.d -DU_USING_ICU_NAMESPACE=0 -DHAVE_DLOPEN=0 -DUCONFIG_ONLY_HTML_CONVERSION=1 -DU_CHARSET_IS_UTF8=1 -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DDISABLE_NACL -DU_STATIC_IMPLEMENTATION -DCHROMIUM_BUILD -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DU_COMMON_IMPLEMENTATION -DU_ICUDATAENTRY_IN_COMMON -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen -fstack-protector --param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wno-extra -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -Wno-deprecated-declarations -Wno-unused-function -m32 -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -frtti -Wno-deprecated -std=gnu++11 -Wno-narrowing  -c ../../third_party/icu/source/common/servlk.cpp -o obj.host/third_party/icu/source/common/icuuc.servlk.o
	| In file included from /usr/include/features.h:389:0,
	|                  from /usr/include/stdint.h:25,
	|                  from /usr/lib64/gcc/x86_64-suse-linux/4.8/include/stdint.h:9,
	|                  from ../../third_party/icu/source/common/unicode/ptypes.h:66,
	|                  from ../../third_party/icu/source/common/unicode/umachine.h:44,
	|                  from ../../third_party/icu/source/common/unicode/utypes.h:36,
	|                  from ../../third_party/icu/source/common/servlk.cpp:9:
	| /usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory
	|  # include <gnu/stubs-32.h>
	|                            ^
	| compilation terminated.