[oe] [meta-browser][PATCH v2] chromium-wayland: update to 53.0.2785.14

[Jacobo Aragunde Pérez]

On 27/01/17 15:06, Julien Brianceau (jbriance) wrote:
>> ...
>> On 1/25/17 9:50 PM, Herve Jourdain wrote:
>>> Hi Jacob,
>>>
>>> I've been able to compile chromium-wayland 53.0.2785.14 on
>> RaspberryPi, with Wayland only (no X11), BUT I had to add an additional
>> patch for it to work, or else I get an error in
>> ui/events/keycodes/keyboard_code_conversion_xkb.cc.
>>> I'm using VC4, which has a DRM/KMS interface (it seems that DRM
>> interface is required by ozone-wayland), but this patch seems to not be
>> related to RaspberryPi itself.
>>> Basically, it seems that USE_XKBCOMMON is not defined when compiling
>> keycodes.
>>>
>>> Is it something that you saw as well? Or do you have a different
>> setting/experience?
>>>
>>> Just for reference, here is the patch I need (right now, I'm
>> triggering it from meta-raspberrypi, but I believe it may be needed in
>> meta-browser).
>>>
>>> --- a/ui/events/keycodes/events_keycodes.gyp	2017-01-23
>> 19:12:01.767271256 +0800
>>> +++ b/ui/events/keycodes/events_keycodes.gyp	2017-01-23
>> 19:12:11.503048216 +0800
>>> @@ -21,6 +21,9 @@
>>>          'scoped_xkb.h',
>>>          'xkb_keysym.h',
>>>        ],
>>> +      'defines': [
>>> +        'USE_XKBCOMMON',
>>
>> This seems fine to me. It should also be proposed upstream as well I
>> think.
>>
> 
> For the record, I've already tried to upstream a similar change (see Patch Set 1 of review https://codereview.chromium.org/2239833003/), but only the GN part has been accepted as gyp support has been removed in Chromium 54.
> 

This error definitely rings a bell to me, although I haven't reproduced
it in my latest builds for minnowboard. It could happen with certain
build flags, maybe some of those are enabled for arm builds but not for
intel ones.

The patch looks definitely good, and because gyp is deprecated in
upstream master, I think it's ok to keep it downstream. Thank you :)

-- 
Jacobo