[oe] [meta-oe][PATCH 06/10] opensc: add PACKAGECONFIG openssl

[Kang Kai]

On 2017年07月06日 00:59, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: openembedded-devel-bounces at lists.openembedded.org
>> [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
>> kai.kang at windriver.com
>> Sent: den 5 juli 2017 10:11
>> To: openembedded-devel at lists.openembedded.org
>> Subject: [oe] [meta-oe][PATCH 06/10] opensc: add PACKAGECONFIG openssl
>>
>> From: Kai Kang <kai.kang at windriver.com>
>>
>> Add PACKAGECONFIG openssl to enable or disable build with openssl for
>> opensc. Check DISTRO_FEATURE openssl-no-weak-ciphers. If it exists then
>> remove PACKAGECONFIG openssl for opensc.
>>
>> Signed-off-by: Kai Kang <kai.kang at windriver.com>
>> ---
>>   meta-oe/recipes-support/opensc/opensc_0.16.0.bb | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/meta-oe/recipes-support/opensc/opensc_0.16.0.bb b/meta-
>> oe/recipes-support/opensc/opensc_0.16.0.bb
>> index fd67181..fa7c81d 100644
>> --- a/meta-oe/recipes-support/opensc/opensc_0.16.0.bb
>> +++ b/meta-oe/recipes-support/opensc/opensc_0.16.0.bb
>> @@ -21,6 +21,11 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34"
>>
>>   inherit autotools pkgconfig
>>
>> +PACKAGECONFIG ??= "openssl"
>> +PACKAGECONFIG[openssl] = "--enable-openssl,--disable-openssl,openssl"
>> +
>> +PACKAGECONFIG_remove = "${@bb.utils.contains('DISTRO_FEATURES', 'openssl-no-weak-ciphers', 'openssl', '', d)}"
> It is a bad idea to use _remove like this, because it makes it impossible to
> enable openssl again in a bbappend or via local.conf.

I do this intendedly that if distro feature 'openssl-no-weak-ciphers' 
exists, package config openssl should be removed since opensc will 
compile failed.
If this is not a good solution, just set CONFLICT_DISTRO_FEATURES as for 
other packages.

Thanks,
Kai

> It is better to do it
> like this:
>
> PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'openssl-no-weak-ciphers', '', 'openssl', d)}"
> PACKAGECONFIG[openssl] = "--enable-openssl,--disable-openssl,openssl"
>
> You should do it similarly for poco and postgresql as well.
>
>> +
>>   EXTRA_OECONF = " \
>>       --disable-static \
>>       --enable-openct \
>> --
>> 2.10.1
> //Peter
>
>

-- 
Regards,
Neil | Kai Kang