[oe] [meta-oe][PATCH] libtinyxml2: upgrade to 5.0.1

[Johannes Pointner]

2017-07-11 8:13 GMT+02:00 Maciej Borzęcki <maciej.borzecki at rndity.com>:
> On Thu, Jul 6, 2017 at 11:30 AM, Johannes Pointner
> <johannes.pointner at br-automation.com> wrote:
>> Signed-off-by: Johannes Pointner <johannes.pointner at br-automation.com>
>> ---
>>  .../{libtinyxml2_4.0.1.bb => libtinyxml2_5.0.1.bb}          | 13 ++++++++++++-
>>  1 file changed, 12 insertions(+), 1 deletion(-)
>>  rename meta-oe/recipes-support/libtinyxml2/{libtinyxml2_4.0.1.bb => libtinyxml2_5.0.1.bb} (63%)
>>
>> diff --git a/meta-oe/recipes-support/libtinyxml2/libtinyxml2_4.0.1.bb b/meta-oe/recipes-support/libtinyxml2/libtinyxml2_5.0.1.bb
>> similarity index 63%
>> rename from meta-oe/recipes-support/libtinyxml2/libtinyxml2_4.0.1.bb
>> rename to meta-oe/recipes-support/libtinyxml2/libtinyxml2_5.0.1.bb
>> index 3a6659815..edf836814 100644
>> --- a/meta-oe/recipes-support/libtinyxml2/libtinyxml2_4.0.1.bb
>> +++ b/meta-oe/recipes-support/libtinyxml2/libtinyxml2_5.0.1.bb
>> @@ -6,10 +6,21 @@ LIC_FILES_CHKSUM = "file://tinyxml2.cpp;endline=22;md5=c19221dbd8a66ad3090462af4
>>
>>  SRC_URI = "git://github.com/leethomason/tinyxml2.git"
>>
>> -SRCREV = "74d44acb176f8510abf28ee0a70961eb26631988"
>> +SRCREV = "37bc3aca429f0164adf68c23444540b4a24b5778"
>>
>>  S = "${WORKDIR}/git"
>>
>>  inherit cmake
>>
>> +FILES_${PN} = " \
>> +    ${libdir}/lib*${SOLIBS} \
>> +    ${includedir}/* \
>
> pretty sure whatever is in ${includedir} it should be a part of -dev package.
You are right.
But this would still leave us with this rule:
FILES_${PN}-dev = " \
    ${includedir}/* \
    ${libdir}/lib*${SOLIBSDEV} \
    ${libdir}/cmake/* \
    ${libdir}/pkgconfig/* \
    "
Is this OK?
>
>> +    "
>> +
>> +FILES_${PN}-dev = " \
>> +    ${libdir}/lib*${SOLIBSDEV} \
>> +    ${libdir}/cmake/* \
>> +    ${libdir}/pkgconfig/* \
>> +    "
>> +
>>  BBCLASSEXTEND = "native"
>> --
>> 2.13.2
>>
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>
> --
> Maciej Borzecki
> RnDity
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel