[oe] [PATCH] Make use of the new bb.utils.filter() function

Martin Jansa martin.jansa at gmail.com
Thu Mar 2 20:48:31 UTC 2017


I agree with Andreas, but I'm not opposed to this so strongly.

Especially as similar patch for oe-core (changing 81 files) was already
merged. Similarly the getVar cleanup recently will also cause some
headaches when cherry-picking. Unfortunately my "safe" (as it won't break
the build) whitespace cleanup won't ever get merged to oe-core, because
it's "too intrusive" :/.

Someone else with another opinion?

On Wed, Mar 1, 2017 at 11:02 PM, Andreas Müller <
schnitzeltony at googlemail.com> wrote:

> On Wed, Mar 1, 2017 at 6:30 PM, Peter Kjellerstedt
> <peter.kjellerstedt at axis.com> wrote:
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
>
> TBH: I don't like this patch:
>
> * It combines things which do not share same labels by design. Naming
> package-configs with same label as distro-feature is a nice to have
> but not a design rule.
> * To me old style explains better what's going on
> * Heavy-gozilla-patches tend to cause headaches when cherry-picking to
> older release branches. And yes I know we had these patches in the
> past and nobody complained.
>
> Andreas
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>



More information about the Openembedded-devel mailing list