[oe] [meta-oe][PATCH] lvm2: fix bash depends QA issue

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org
> [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
> Armin Kuster
> Sent: den 11 mars 2017 21:59
> To: openembedded-devel at lists.openembedded.org
> Subject: [oe] [meta-oe][PATCH] lvm2: fix bash depends QA issue
> 
> WARNING: lvm2-2.02.166-r0 do_package_qa: QA Issue: /etc/init.d/lvm2-
> monitor contained in package lvm2 requires /bin/bash, but no providers
> found in RDEPENDS_lvm2? [file-rdeps]
> 
> Signed-off-by: Armin Kuster <akuster808 at gmail.com>
> ---
>  meta-oe/recipes-support/lvm2/lvm2.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-
> support/lvm2/lvm2.inc
> index b25d775..3e79552 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
> @@ -98,6 +98,7 @@ FILES_libdevmapper-dev = " \
>  "
> 
>  RDEPENDS_${PN}-scripts = "${PN} (= ${EXTENDPKGV}) bash"
> +RDEPENDS_${PN} = " bash"

That defeats the whole purpose of moving the bash scripts to ${PN}-scripts.
The reason I have not seen this is because that script is only installed if 
the dmeventd PACKAGECONFIG is enabled (which we do not have). So at least 
make this conditional on that PACKAGECONFIG. Even better would be to patch 
scripts/lvm2_monitoring_init_red_hat.in (that lvm2-monitor is installed 
from) to not be a bash script. The only bashism that I can find in the 
script is the use of $"..." when printing the usage instruction (line 131). 
However, since no other messages in that script are localized, I do not see 
a point in localizing that one, and the $"..." can be changed to "..."

>  RDEPENDS_libdevmapper-dev = "libdevmapper (= ${EXTENDPKGV})"
>  RRECOMMENDS_${PN} = "${PN}-scripts (= ${EXTENDPKGV})"
> 
> --
> 2.7.4

//Peter